Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1970951img; Sat, 23 Mar 2019 18:22:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqyX5/OcdKJf70pk26RKxGhgDCMI2mISFeDx0q0XD+SpT8CCZ1yog3vM9rkngch3jwISUpkq X-Received: by 2002:a63:570d:: with SMTP id l13mr8748099pgb.55.1553390556605; Sat, 23 Mar 2019 18:22:36 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553390556; cv=none; d=google.com; s=arc-20160816; b=Trmb7qvlo4RPWqwpW3O1aRtcOWbxl/pzMucYlcE/IkQlc17+cjWccndAumI4tapgy6 QQlWgn70YGM6oQJXnT+6XKLoMD6ud2bzCDSMYDBMAJNMw7B7/ckXo+402gDf795N3kI8 1g5otkLG/qBaGAN76F+iApuGG+3gglUtqbiOlJH86MTOVMRFalZ74m2a99k8rUvG+/gV RhaftonNm5xPjSMbhNw6EZMm5CokQNbL0ZYt+70wEl5akwW45WAtqFGEsjY/V58xV+D+ lMxNnpD0MEQLWUKbWO3vfuxJPMOEntC6OAI9kCKT6xyKdSZHEQEGJzDtFCLbdGAdO24o 5iyg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=rLJLwcohJVr3qo4XgcdYEWHccApbwwvTBVkc8kVHrmU=; b=sj8cPwZ09X53kZ6FGocI6YPaXtF8fn3fURfdW7Z95EofIGvgeE+a6bCY9CsF2chFX6 qIzCUNWiJE/l4fMJIaXsasaTgPJVbwsF4DxjGADhPgiCDmbFGte4rSyCwEB2IG7XBk5e O/2jhLzYVnfkfK6OwaEsqQ6nVx929dcpEL9xWVkxqdp7v+vCPTy+1bUNCwrmxRNRDjZe uyfXfSYZTKekIJjeEop63ikZoaf7oDOe3+BPxpvq9A76uIf3cPZ/F6X3E1PDLR7VqVoN IcodY8l+i8ZTA1SfWbRqcuZUhDMj/ELH9YFOYeqcKugH2Uaazgkc0V9rYl6MYGn8th/x uxcw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 189si10339000pgb.412.2019.03.23.18.22.21; Sat, 23 Mar 2019 18:22:36 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728048AbfCXBVp (ORCPT + 99 others); Sat, 23 Mar 2019 21:21:45 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35094 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727635AbfCXBVp (ORCPT ); Sat, 23 Mar 2019 21:21:45 -0400 Received: from localhost (unknown [50.233.106.125]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id BADFB14B479B4; Sat, 23 Mar 2019 18:21:44 -0700 (PDT) Date: Sat, 23 Mar 2019 21:21:44 -0400 (EDT) Message-Id: <20190323.212144.1996374900941336844.davem@davemloft.net> To: wen.yang99@zte.com.cn Cc: linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn, anirudh@xilinx.com, John.Linn@xilinx.com, michal.simek@xilinx.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 1/3] net: xilinx: fix possible object reference leak From: David Miller In-Reply-To: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> References: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 23 Mar 2019 18:21:44 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang Date: Fri, 22 Mar 2019 11:04:07 +0800 > The call to of_parse_phandle returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1624:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 1569, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang Applied.