Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp1971024img; Sat, 23 Mar 2019 18:22:50 -0700 (PDT) X-Google-Smtp-Source: APXvYqwkvqBDVKyYCZx1alAyT3Z+K+9cKmJVttUPg1JjqOzuPkzEKcWZj/CQMrDtB9LKeL0lncb5 X-Received: by 2002:a17:902:1c9:: with SMTP id b67mr17179414plb.176.1553390570793; Sat, 23 Mar 2019 18:22:50 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553390570; cv=none; d=google.com; s=arc-20160816; b=07QuEu8Pbp3RnmZTSQJYGIylBbvJ4gx8ONgNDwrFmo0TQJG7m4+7waztswZoAMTv+n mPObymGdOBgyQnCsmrk1qIuPhGzfCME9Q3K5ROMMrmCRqWnwyIaIwucd/PjpK6Rqh+96 O24RiKaQTTWgmNcbHN3/oIWOjDwCKXAEyJpkKPQF8+YM+ZVCXlQNnzKu8DMzn9bcxjsh KP62WG5XizsWf+MH9gW77EflAWTJGSipYHuF5iOSBWlpqPEnOIPXB8V2YUko0LQ7CL90 jBVIOmRUDkZjOptDeZQubstaEJ5WHz2U3taQMtfppaBlbzN8satmYB4nRMlbdnBdLRxh g7dQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=J1kPHbKu9BNn0sMejndS7fCeTHN8cZl3dfH+82vr/KA=; b=0UErFA0vUsFkDlbiQEy5H+9S70yj0nxgHXryf4eDVBO/5og5VS03B7EWww2qVrYcNt lOrt5TPodvM5w7P5KLKZBo1NqZbEQpsAMEiVdYa0j4zdo36+LaP6rGRHY9HhOL40Uyp4 r28RkNCVg+744r2BhgLuwoXUXFSFBpJ3aE0kLuaBivXwlv5A1937tpKW87jqjLne09de 93TIjUdn+j8zYCX2x/clse7jt4h/s+moVXANe/BAHUMnw/xfbh+Xl8sMBTXtErTB33AW 8csF+pTfuA1oal/rDvmaxK5DHR9EUkB3bzBtvE9VsKos8hy6/M374+2fF/Xj3l/OK1zo 0yHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id u185si4758733pgd.489.2019.03.23.18.22.36; Sat, 23 Mar 2019 18:22:50 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728151AbfCXBV4 (ORCPT + 99 others); Sat, 23 Mar 2019 21:21:56 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:35104 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727635AbfCXBV4 (ORCPT ); Sat, 23 Mar 2019 21:21:56 -0400 Received: from localhost (unknown [50.233.106.125]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 1C79A14B479B4; Sat, 23 Mar 2019 18:21:56 -0700 (PDT) Date: Sat, 23 Mar 2019 21:21:55 -0400 (EDT) Message-Id: <20190323.212155.1537951760061802531.davem@davemloft.net> To: wen.yang99@zte.com.cn Cc: linux-kernel@vger.kernel.org, wang.yi59@zte.com.cn, dougmill@linux.ibm.com, netdev@vger.kernel.org Subject: Re: [PATCH 2/3] net: ibm: fix possible object reference leak From: David Miller In-Reply-To: <1553223849-7143-2-git-send-email-wen.yang99@zte.com.cn> References: <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn> <1553223849-7143-2-git-send-email-wen.yang99@zte.com.cn> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sat, 23 Mar 2019 18:21:56 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Wen Yang Date: Fri, 22 Mar 2019 11:04:08 +0800 > The call to ehea_get_eth_dn returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./drivers/net/ethernet/ibm/ehea/ehea_main.c:3163:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 3154, but without a corresponding object release within this function. > > Signed-off-by: Wen Yang Applied.