Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1553398466.26628.0.camel@mtksdaap41>
Subject: Re: [PATCH 09/24] mmc: mtk-sd: check for valid optional memory
 resource
From:   Yingjoe Chen <yingjoe.chen@mediatek.com>
To:     Fabien Parent <fparent@baylibre.com>
CC:     <matthias.bgg@gmail.com>, <robh+dt@kernel.org>,
        <mark.rutland@arm.com>, <linux-arm-kernel@lists.infradead.org>,
        <devicetree@vger.kernel.org>, <ryder.lee@mediatek.com>,
        <linux-watchdog@vger.kernel.org>, <jjian.zhou@mediatek.com>,
        <wenzhen.yu@mediatek.com>, <stephane.leprovost@mediatek.com>,
        <sean.wang@kernel.org>, <linux-mmc@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <yong.mao@mediatek.com>,
        <linux-spi@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
        <linux-mediatek@lists.infradead.org>,
        <hsin-hsiung.wang@mediatek.com>, <linux-serial@vger.kernel.org>,
        <linux-clk@vger.kernel.org>, <chaotian.jing@mediatek.com>,
        <linux-i2c@vger.kernel.org>
Date:   Sun, 24 Mar 2019 11:34:26 +0800
In-Reply-To: <20190323211612.860-10-fparent@baylibre.com>
References: <20190323211612.860-1-fparent@baylibre.com>
         <20190323211612.860-10-fparent@baylibre.com>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sat, 2019-03-23 at 22:15 +0100, Fabien Parent wrote:
> 'top_base' memory region is optional. Check that the resource is valid
> before using it. This avoid getting a "invalid resource" error message
> printed by the kernel.
> 
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
> ---
>  drivers/mmc/host/mtk-sd.c | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mmc/host/mtk-sd.c b/drivers/mmc/host/mtk-sd.c
> index 833ef0590af8..573aa127d00b 100644
> --- a/drivers/mmc/host/mtk-sd.c
> +++ b/drivers/mmc/host/mtk-sd.c
> @@ -2123,9 +2123,11 @@ static int msdc_drv_probe(struct platform_device *pdev)
>  	}
>  
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 1);
> -	host->top_base = devm_ioremap_resource(&pdev->dev, res);
> -	if (IS_ERR(host->top_base))
> -		host->top_base = NULL;
> +	if (ret) {

This should be res?

> +		host->top_base = devm_ioremap_resource(&pdev->dev, res);
> +		if (IS_ERR(host->top_base))
> +			host->top_base = NULL;
> +	}
>  
>  	ret = mmc_regulator_get_supply(mmc);
>  	if (ret)