Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp2695593img; Sun, 24 Mar 2019 16:23:32 -0700 (PDT) X-Google-Smtp-Source: APXvYqyLfshBn9jy9UM3KRy2UGSde6h/VVxr8H6gMg9kgS/K13z6hiqBi7xcYhfeMie/XjWxDqVl X-Received: by 2002:a17:902:7e46:: with SMTP id a6mr22284661pln.150.1553469812854; Sun, 24 Mar 2019 16:23:32 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553469812; cv=none; d=google.com; s=arc-20160816; b=DxNnX+SjCf47gegz6pQrV68Bg6xIOQH3X4Ki/XwQuNk3KXdCey6VU71FIC4asCuNGd GU/6/Kpf6dnEKU4x22DHRcbcviQNBDrolvqzS8i6APzDZq73vzUV9OpwIRXMbyhFka9G RI73hWR21sJKunG7XLinVU1hXGELgP86Sg4t0ae94t3uiudSkYCPRGtLCHvXUmViEX8G NxxE+odcJgrSDWznTnFwv7w2CpgJMi2tHu1EQd4ncDwHll/emLcEoL0XjWM3Ojq5EoJ/ HCfLvpvMwNjmXiL0CXPuV7pAan6O+bMrp6NsLaYGT/cyXQ/Qy/blo/i9vRTKhYtnvmtN L9wA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=41fkJ68HbV1EubuETozIxJ2sQJNbc/APWw+PYFA9ZNg=; b=k8NxLQMXhHK3W+526DFUFiEUnO4GbN9LrpoIRqFyBdFgbFbCPAuz0DdBWaMltSaMfA s5NgRFN07Zv/83AGTpf9hZN13Uwq4/uDd2f6WsxV4+VM9OI07ZG2FYQHeCcdx0PIfyBu gs/Ea4H1tqA0Fb8iMPosTeTifBDWIcZj/x/fN6HTF2mpxAwFr3/fYyCGh4ffosXa+HN2 r6DPJW5gpuIy55fm+q3klczfts9Pgmd1NwVIf/DlNhE1GHNlFsItYkq0Zn7pni0vtb0Y GHJwQoDcwfaQ4KMhgRDkAAQ7oaSCIrwKP/BaDmp3ImwsrOR5YnTm8Jq3bNvUNLAwpbEO Pxug== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=cDTJSBDg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b2si6630841pgn.93.2019.03.24.16.23.17; Sun, 24 Mar 2019 16:23:32 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=cDTJSBDg; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729107AbfCXXVS (ORCPT + 99 others); Sun, 24 Mar 2019 19:21:18 -0400 Received: from mta-p6.oit.umn.edu ([134.84.196.206]:41818 "EHLO mta-p6.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727275AbfCXXVR (ORCPT ); Sun, 24 Mar 2019 19:21:17 -0400 Received: from localhost (unknown [127.0.0.1]) by mta-p6.oit.umn.edu (Postfix) with ESMTP id 2CD63909 for ; Sun, 24 Mar 2019 23:21:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p6.oit.umn.edu ([127.0.0.1]) by localhost (mta-p6.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4E_PWBab9Grf for ; Sun, 24 Mar 2019 18:21:16 -0500 (CDT) Received: from mail-it1-f198.google.com (mail-it1-f198.google.com [209.85.166.198]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p6.oit.umn.edu (Postfix) with ESMTPS id 020185EC for ; Sun, 24 Mar 2019 18:21:16 -0500 (CDT) Received: by mail-it1-f198.google.com with SMTP id s21so7017938ite.6 for ; Sun, 24 Mar 2019 16:21:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=41fkJ68HbV1EubuETozIxJ2sQJNbc/APWw+PYFA9ZNg=; b=cDTJSBDgz9nITl5fN5sj4xglZ4y0ueJVn0zpvT3JQzSd86oPcDMOAX/Vqj36X3RqA1 1WDxSsuJyXbNQrtFT+zxa/53/xbIVaeO4allLaWanYH5yt0BClYRqCplWwd5F84wNyDn MPTywDihlddPxn+W8FYGsB6ABMKMTlVe/zIjbUolzYTRv+rRmfWf3gmGWHGb/qaooAjE mvqS7WP5nePxgnXuVpH3sn+dSq0U5ewf75kMneWLfVy1+PpHGutqxPtmL4swff6IReCy ioga6P8XJXqYeJ4pQojC4wSALEDJR+b49/Vxx4+Kz7gZXRgr58Lj9cq9C9CyFwePCWzO F83Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=41fkJ68HbV1EubuETozIxJ2sQJNbc/APWw+PYFA9ZNg=; b=TRaAkpPLUaczPyncyvr2UnGxDMGi0nyphaDXAFmYyBcDPmIJD4p7HgJWWA44TQJGc6 oVlAPqppqlQvKhdPBq6fijLvRUxzNWDI+udKj39pF8BKZbbZTxwZWYGRRxajsUJ2bvXm xFhR7Ce7QcSQh5c2IfEbeakEA4CZUISFQOhUqhNz0Hroqoekl1BkDWnURQZsIykbuEvg sT1s0U1R7KkcT4HOD6LywINMrAt7R2+dRrye78Hy2NkCzFur8LmtTqRumT8HhgGwVMbu ezoziJVuEql9FUO+rNx3hTYiDBxYPTVLAx2LOFbkHbQkupXoEpQ0xWu7jjWvaPu150Sj 8RHg== X-Gm-Message-State: APjAAAUCdc6pTBcE1UHHZm98EHQQEu6XTCI5/ARQvbDrlyMTyIZZHjbw Pe3gf8CzSp4G4VNd6GWzfF211aLslxWtWpLfbvIVvdLaimDut/nQBCkmgV4ulXJRsAQR/0+Esep OA9sFYuU/cTH/JAQKL/dLl7K+Qbxl X-Received: by 2002:a05:660c:606:: with SMTP id i6mr5694552itk.154.1553469675670; Sun, 24 Mar 2019 16:21:15 -0700 (PDT) X-Received: by 2002:a05:660c:606:: with SMTP id i6mr5694545itk.154.1553469675429; Sun, 24 Mar 2019 16:21:15 -0700 (PDT) Received: from bee.dtc.umn.edu (cs-bee-u.cs.umn.edu. [128.101.106.63]) by smtp.gmail.com with ESMTPSA id x79sm4327143ita.17.2019.03.24.16.21.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 24 Mar 2019 16:21:14 -0700 (PDT) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Olli Salonen , Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: tuners: fix a missing check for regmap_write_bits Date: Sun, 24 Mar 2019 18:21:10 -0500 Message-Id: <20190324232110.2804-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.1 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org regmap_write_bits could fail and thus deserves a check. The fix returns its error code upstream in case it fails. Signed-off-by: Kangjie Lu --- drivers/media/tuners/tda18250.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/tuners/tda18250.c b/drivers/media/tuners/tda18250.c index 20d10ef45ab6..36ede1b02d23 100644 --- a/drivers/media/tuners/tda18250.c +++ b/drivers/media/tuners/tda18250.c @@ -703,6 +703,8 @@ static int tda18250_set_params(struct dvb_frontend *fe) /* charge pump */ ret = regmap_write_bits(dev->regmap, R46_CPUMP, 0x07, buf[2]); + if (ret) + goto err; return 0; err: -- 2.17.1