Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH net] netlink: fix a memory leak on error path
To:     Kirill Tkhai <ktkhai@virtuozzo.com>, davem@davemloft.net
Cc:     keescook@chromium.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
References: <20190322105845.25046-1-cgxu519@gmx.com>
 <2acfd376-7b25-5eeb-2770-413b880bd4d9@virtuozzo.com>
From:   cgxu519 <cgxu519@gmx.com>
Message-ID: <786f1aec-fe47-f060-6f6e-4307ecaff82d@gmx.com>
Date:   Mon, 25 Mar 2019 09:19:04 +0800
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.0
MIME-Version: 1.0
In-Reply-To: <2acfd376-7b25-5eeb-2770-413b880bd4d9@virtuozzo.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/22/19 7:03 PM, Kirill Tkhai wrote:
> Hi, Chengguang,
>
> On 22.03.2019 13:58, Chengguang Xu wrote:
>> In genl_register_family(), when idr_alloc() fails,
>> we forget to free family->attrbuf.
>>
>> Note, some callers call genl_unregister_family() to clean up
>> on error path, it doesn't work because the family is inserted
>> to the global list in the nearly last step.
>>
>> Fixes: 2ae0f17df1c ("genetlink: use idr to track families").
>> Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
> have you seen https://patchwork.ozlabs.org/patch/1059834/ ?

Sorry, I didn't notice that because I'm mainly working on linus-tree.
Please just ignore this patch.

Thanks.