Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190324110804.68555-1-anup.patel@wdc.com> <LO2P265MB08478847A45E7617FD906F8CD65D0@LO2P265MB0847.GBRP265.PROD.OUTLOOK.COM>
In-Reply-To: <LO2P265MB08478847A45E7617FD906F8CD65D0@LO2P265MB0847.GBRP265.PROD.OUTLOOK.COM>
From:   Anup Patel <anup@brainfault.org>
Date:   Mon, 25 Mar 2019 08:51:31 +0530
Message-ID: <CAAhSdy0+9rgJtxjhrYAEt1Tem79ixL7sSKUHp63Hf-5sb+31+Q@mail.gmail.com>
Subject: Re: [PATCH] RISC-V: Always compile mm/init.c with cmodel=medany
To:     Gary Guo <gary@garyguo.net>
Cc:     Anup Patel <Anup.Patel@wdc.com>,
        Palmer Dabbelt <palmer@sifive.com>,
        Albert Ou <aou@eecs.berkeley.edu>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Mike Rapoport <rppt@linux.ibm.com>,
        Christoph Hellwig <hch@infradead.org>,
        Atish Patra <Atish.Patra@wdc.com>,
        Paul Walmsley <paul.walmsley@sifive.com>,
        "linux-riscv@lists.infradead.org" <linux-riscv@lists.infradead.org>,
        Christoph Hellwig <hch@lst.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 25, 2019 at 12:44 AM Gary Guo <gary@garyguo.net> wrote:
>
>
>
> > -----Original Message-----
> > From: linux-riscv <linux-riscv-bounces@lists.infradead.org> On Behalf O=
f Anup
> > Patel
> > Sent: Sunday, March 24, 2019 11:08
> > To: Palmer Dabbelt <palmer@sifive.com>; Albert Ou <aou@eecs.berkeley.ed=
u>
> > Cc: Anup Patel <Anup.Patel@wdc.com>; linux-kernel@vger.kernel.org; Mike
> > Rapoport <rppt@linux.ibm.com>; Christoph Hellwig <hch@infradead.org>; A=
tish
> > Patra <Atish.Patra@wdc.com>; Paul Walmsley <paul.walmsley@sifive.com>;
> > linux-riscv@lists.infradead.org; Christoph Hellwig <hch@lst.de>
> > Subject: [PATCH] RISC-V: Always compile mm/init.c with cmodel=3Dmedany
> >
> > diff --git a/arch/riscv/mm/Makefile b/arch/riscv/mm/Makefile
> > index eb22ab49b3e0..7307609d405b 100644
> > --- a/arch/riscv/mm/Makefile
> > +++ b/arch/riscv/mm/Makefile
> > @@ -3,3 +3,5 @@ obj-y +=3D fault.o
> >  obj-y +=3D extable.o
> >  obj-y +=3D ioremap.o
> >  obj-y +=3D cacheflush.o
> > +
> > +CFLAGS_init.o :=3D -mcmodel=3Dmedany
>
> I think you should also remove CFLAGS_setup.o from kernel/Makefile, as I =
think it was there solely for the correctness of setup_vm. As setup_vm is n=
ow in mm/init.o, the old CFLAGS probably isn't needed and should be removed=
 in the same patch. Disclaimer: I haven't tested it.

Sure, I will remove it in v2 patch. Thanks for catching.

Regards,
Anup