Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp2872101img; Sun, 24 Mar 2019 21:55:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqwvU+P899tWYy00m0k2qKiejZbEYqff0UG9oie7Sofoz5yKFcU6nqRYn6iwzFvPamXa9t20 X-Received: by 2002:a62:1d0e:: with SMTP id d14mr21572766pfd.73.1553489725632; Sun, 24 Mar 2019 21:55:25 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553489725; cv=none; d=google.com; s=arc-20160816; b=n3Xs3FTAhkZly/AJxnw1ZTkenCHj3zn0ljd/46LBDKS2ksWgmhg73R81PX39EuRFrj EYA5fmiyaA6K7wTw9GEdn77lAFtK/rUg1igbGN+nYcoTOXDWvvGEjdySMbiuxlK6vPCo IcAxzilM21GZxuVh8GxvOp0OFiJfeJjZqjobtC61STpGiRKzwBLr4U+qKIzhU7fn6ktx vELwXSpoI2+uzQ2A9TCzXAD93bwu3Un2bVv8fi5kV4uBDSSEeiGSwBNqz/wIQwBDdsZz Jj9n8pCHKPOZFR5C0sfX/TyHJyqwEI6HJ8z0dPuXTxrQ+rT/U7Cb9cwkOgINnD1IbfBQ z4uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=72PbruoSFa2qrjWpZxBUd5ZAD7zfepEn7jht2DmQ7TI=; b=t7lL1BN93SgRthTOprPMHaZAd6sLxZy0GaG66dXF8h/aWo5nBv+vso0s+4H9dHttXi ePYzBoeidrfIuTaX1k1KBQfdsx22rz4Qb6eom8+jE3BzmgCLRp7/apfq1jW4Lvmi2qJL bhucNT08hrBIBL/PKVS+Ig6ycU9u/gUHpn9xOu5j/wicM6Jy3ol5+22Zvz+/CGdJlG6S 7Uq/Wx1jkd7tDArY4H8llDO2zOnbSW3MRckYgyCSh/heNfIfOXX2NgGK/LPCj7K4SkC4 rFR7HrePiVFFROySZKAPwuS4afb8JuBss1uSZhYjYSDHyJQZEcDxtRI9nb0Pux4Kfguy KMeA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="wVXwSam/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d16si12597512pgh.440.2019.03.24.21.55.10; Sun, 24 Mar 2019 21:55:25 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="wVXwSam/"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726242AbfCYEyf (ORCPT + 99 others); Mon, 25 Mar 2019 00:54:35 -0400 Received: from mail.kernel.org ([198.145.29.99]:44938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725810AbfCYEyf (ORCPT ); Mon, 25 Mar 2019 00:54:35 -0400 Received: from localhost (unknown [171.61.95.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 323802087E; Mon, 25 Mar 2019 04:54:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553489674; bh=ueBgVV70DJvt8SSwprL82/xnIWLBpMIINVj7pPcdztE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wVXwSam/KFMHk1gTkzLjmBngMLUlCuiYpOSdKDgSfmicoaC5HBF+fqPRUNlCvASi0 3CD381YtKVFhPzYQ2xbL2sbmuif/kYOANQTLfVgjSz3b4seFLcPjRUOHZSjmKfFGpp OdnHMuB9E+GzNco/sjnc+u0qgQJQHrBPoDuw/BMw= Date: Mon, 25 Mar 2019 10:24:29 +0530 From: Vinod Koul To: Sameer Pujar Cc: dan.j.williams@intel.com, treding@nvidia.com, jonathanh@nvidia.com, dmaengine@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v3 1/2] dmaengine: tegra210-adma: use devm_clk_*() helpers Message-ID: <20190325045429.GF5348@vkoul-mobl> References: <1552476757-22360-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1552476757-22360-1-git-send-email-spujar@nvidia.com> User-Agent: Mutt/1.11.3 (2019-02-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 13-03-19, 17:02, Sameer Pujar wrote: > adma driver is using pm_clk_*() interface for managing clock resources. > With this it is observed that clocks remain ON always. This happens on > Tegra devices which use BPMP co-processor to manage clock resources, > where clocks are enabled during prepare phase. This is necessary because > clocks to BPMP are always blocking. When pm_clk_*() interface is used on > such Tegra devices, clock prepare count is not balanced till remove call > happens for the driver and hence clocks are seen ON always. Thus this > patch replaces pm_clk_*() with devm_clk_*() framework. Both applied, thanks -- ~Vinod