Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp2895750img; Sun, 24 Mar 2019 22:38:21 -0700 (PDT) X-Google-Smtp-Source: APXvYqxs3PQ1NEzUHrztLcj54ozZm0QEl4JGzK+wpTcXE1ZJo997zIr4fx6cCZ2RJhCJAO4CSS38 X-Received: by 2002:a65:53cb:: with SMTP id z11mr21035778pgr.139.1553492301395; Sun, 24 Mar 2019 22:38:21 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553492301; cv=none; d=google.com; s=arc-20160816; b=qvc2C3fPyhjawMea2g+SvK9lVSibulSAOEM8sNIZ0fD9hKTHu0+bY4zOH26NRZ3J3r I7Mw33uX9omwv47is2SHYoH8RYFndT/fRuYrIPcGmury01PeaoUQWlthT2HWMQl7ICo1 h0746o3PIKd3B/MtyzL8ARZb+wZHLo+FutomP7TpMld+zecgpx20oURgfy6ih+Zxm1/h NSATb5WrkGeTDSkutMpDyfnlikJOtZe4ioNyc4VToTCNBlgE0+Ogr1z2kecF/eGz36hK 0dcvzp61O4myVhkF5gH/J8+3jLAqKJWw2PcB1BHy1+1o/wZB5RgUiUyNFLyT8Vh7pvHK Et5g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=ss1t3DJAWRqtk33Piyd+aeKtdRJeAop5F6RCCUL08C8=; b=DqDArCGw3qk/VsvdXFnUlcws5OUN7BKXFRuiCjz4I3r5KVanZ8ZsR73mp3XsvCvThq F/B9Uky3OiCjlL4YjhxtcfetXJFSvS6WvzWUnatMoDQLajMdMWVpAsotYySOS4ZnCyvm cpKMWOApI6dn+Ktd4kTb7HFJ6t4UYgJa7gJG0QSlZauF6V0jwgL4cSoiBCSBBrbjs9wU g3+ts0PEOApU88MCq4hQEM/KmS5lxrTM3l2+H+lt6mKMMY6l/WJZH6LpHlZc8AA5alMR LWIG3r7rfuoMMa1PeGhIfd8sPSwN1v9KuD/r1jG4+75AUuJShBjEX/nYaLXdi90p02re EYxg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=xFkS5Gq+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z4si5257467plo.166.2019.03.24.22.38.06; Sun, 24 Mar 2019 22:38:21 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=xFkS5Gq+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729608AbfCYFhS (ORCPT + 99 others); Mon, 25 Mar 2019 01:37:18 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:59672 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729493AbfCYFhQ (ORCPT ); Mon, 25 Mar 2019 01:37:16 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2P5Y5vv005446; Mon, 25 Mar 2019 05:36:52 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=ss1t3DJAWRqtk33Piyd+aeKtdRJeAop5F6RCCUL08C8=; b=xFkS5Gq+43hARkWeK8oqfIGvo7CAhwSBo/prJLfsrWEYBk1H66YtBnGqdjWZXuxKyar2 1t6cMePhuWnf6241PNLLw629bGn8slCPVdw3q7L7+ZvQve146JgLm7/1K63wL5IGOvYx /ZYfK1TG0tAEG0qD4dw35tS6SMyTCesWn1ywW/R3pGgvvKCJFiozT9gzL0KBcrN8NZg7 L+WmGP1A6eD18ToXee5CVNTa9eloMI7gsfOtZK++zsH0mpS0X2C5GUmD2wuvvusE74p0 UALRgbv+QlXxtdkuUQTOYeXrL4LCIFilpaVp9NwsefmM8t//j23IBJZxB7U+SxNUo4yG kw== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2re6dj1tqt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Mar 2019 05:36:52 +0000 Received: from userv0121.oracle.com (userv0121.oracle.com [156.151.31.72]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x2P5akVv021478 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Mar 2019 05:36:46 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by userv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2P5ajYc009009; Mon, 25 Mar 2019 05:36:45 GMT Received: from will-ThinkCentre-M93p.cn.oracle.com (/10.182.71.12) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 24 Mar 2019 22:36:45 -0700 From: Jianchao Wang To: axboe@kernel.dk Cc: hch@lst.de, jthumshirn@suse.de, hare@suse.de, josef@toxicpanda.com, bvanassche@acm.org, sagi@grimberg.me, keith.busch@intel.com, jsmart2021@gmail.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 6/8] skd: use blk_mq_queue_tag_inflight_iter Date: Mon, 25 Mar 2019 13:28:07 +0800 Message-Id: <1553491689-1730-7-git-send-email-jianchao.w.wang@oracle.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1553491689-1730-1-git-send-email-jianchao.w.wang@oracle.com> References: <1553491689-1730-1-git-send-email-jianchao.w.wang@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9205 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903250043 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org blk_mq_tagset_busy_iter is not safe that it could get stale request in tags->rqs[]. Use blk_mq_queue_tag_inflight_iter here. Signed-off-by: Jianchao Wang --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 7d3ad6c..0213b19 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -395,7 +395,7 @@ static int skd_in_flight(struct skd_device *skdev) { int count = 0; - blk_mq_tagset_busy_iter(&skdev->tag_set, skd_inc_in_flight, &count); + blk_mq_queue_tag_inflight_iter(skdev->queue, skd_inc_in_flight, &count); return count; } @@ -1916,7 +1916,7 @@ static bool skd_recover_request(struct request *req, void *data, bool reserved) static void skd_recover_requests(struct skd_device *skdev) { - blk_mq_tagset_busy_iter(&skdev->tag_set, skd_recover_request, skdev); + blk_mq_queue_tag_inflight_iter(skdev->queue, skd_recover_request, skdev); } static void skd_isr_msg_from_dev(struct skd_device *skdev) -- 2.7.4