Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp2897187img; Sun, 24 Mar 2019 22:40:36 -0700 (PDT) X-Google-Smtp-Source: APXvYqxAaT/CXXpubg8CxmpBcw0hl+MHdGmX3ePRom8GoR6sKUvRD+qkd7LDO/8nss3tyTWtrTIa X-Received: by 2002:a63:c00c:: with SMTP id h12mr21837866pgg.423.1553492435979; Sun, 24 Mar 2019 22:40:35 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553492435; cv=none; d=google.com; s=arc-20160816; b=ZHayvTHqwSqpV37FFNDlwHYd0SbtDQeQ00wzb6xzCOtTgH0IE5400bVjG3gTlwYVtD EmW44tK7WnITHHe1WN4eV5z99dbztpgzFLNGGdjkVQTHauJCuM6kJH4NwQr83oBCGzEP yTlWvwsOnwTmV+bHm/ExZSwYMk/lsBcpabgs1+Iy1OfmAGXQGD0/P5+gzSkXkcv4kwBG xlVQkyr8sOrFBCQG09FAdw4QQ5OiZNJ23v6q8Z2iWOqHlLEFV8n4K6mnJByTY7Azpv4P vXh/N+eGM1SVG3CAgjAmmzC3l6UkS278Y588ImjX482f3J6Q38XQAWUJ48m3QXiDEjQb q9ew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=HFHaBCUZ8wMa3FAx2XARpXITPf6N64mPFcEnLvMxejg=; b=JZUF+vmn2r4nvPSinFpqhG4v2kbixpNQMvdZspbq/fZH5raZvPiaq1E6G76XRLazh/ I1kqMQ/NIzV+2NMJYehwakAun6dYGxqYtq6KQSs5VWi+uyQn6aPJoCVe0/CbPPgzEUbK 199sbCfoZGlc64sC2aRM8s2NdGmfbVehRLtRlJzByIp3o0kr5ILsJY+tKtIr4Utf3au6 1mTf+DIWwbo5+Le6PsDCi2Yq5HQCMBJtlhoNbgimGOjIDfxlB1Vt9ajCOMQmqFmZ5c3Q +DFC1lQzfhU3xwME5eWVtbonCmP3DWr4EwHhfvHJR7qlajVOA8ywglPl45j+2X2A9K1P 7Jqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=KN8jdOaE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q189si12980310pgq.240.2019.03.24.22.40.21; Sun, 24 Mar 2019 22:40:35 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=KN8jdOaE; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729650AbfCYFhk (ORCPT + 99 others); Mon, 25 Mar 2019 01:37:40 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:59454 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729373AbfCYFhC (ORCPT ); Mon, 25 Mar 2019 01:37:02 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2P5Y6EU005450; Mon, 25 Mar 2019 05:36:40 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=HFHaBCUZ8wMa3FAx2XARpXITPf6N64mPFcEnLvMxejg=; b=KN8jdOaEzAIIATdulddaZagWt6aHyaKy+rnq10LI5mfOFE8hJYP9/QeJ4wRCg6sJrZSg 961+SRJY6O0mOQE1VRPLeSEhBjOSkSWhS03tSadtM/bb0hdx70dSuUlN3y+NLqHrrnm7 ZAoJit5+DpNf1AJyysuM4ngZCtL/Ly78XJICprJuMybggwrJRmtb6y8W7eGT4NJObSZS jGadtHUpcjhKzTEqrz4s6uZxl+HquhhY6++2V+57pg8+gJdQ9dIQeRJBVLbrW1T5VMHZ X8sJfFqjPK5kCNnwop9nRH7VsVY/aPoEl7JG8cuCEynraQpO9mnlw2Hbq/raD5PEKM8k 5w== Received: from aserv0022.oracle.com (aserv0022.oracle.com [141.146.126.234]) by userp2120.oracle.com with ESMTP id 2re6dj1tqd-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Mar 2019 05:36:40 +0000 Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0022.oracle.com (8.14.4/8.14.4) with ESMTP id x2P5adEV021312 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Mar 2019 05:36:39 GMT Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id x2P5adXf025252; Mon, 25 Mar 2019 05:36:39 GMT Received: from will-ThinkCentre-M93p.cn.oracle.com (/10.182.71.12) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 24 Mar 2019 22:36:39 -0700 From: Jianchao Wang To: axboe@kernel.dk Cc: hch@lst.de, jthumshirn@suse.de, hare@suse.de, josef@toxicpanda.com, bvanassche@acm.org, sagi@grimberg.me, keith.busch@intel.com, jsmart2021@gmail.com, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 4/8] mtip32xx: use blk_mq_queue_tag_inflight_iter Date: Mon, 25 Mar 2019 13:28:05 +0800 Message-Id: <1553491689-1730-5-git-send-email-jianchao.w.wang@oracle.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1553491689-1730-1-git-send-email-jianchao.w.wang@oracle.com> References: <1553491689-1730-1-git-send-email-jianchao.w.wang@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9205 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=920 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903250043 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org blk_mq_tagset_busy_iter is not safe that it could get stale request in tags->rqs[]. Use blk_mq_queue_tag_inflight_iter here. Signed-off-by: Jianchao Wang --- drivers/block/mtip32xx/mtip32xx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c index 83302ec..103e691 100644 --- a/drivers/block/mtip32xx/mtip32xx.c +++ b/drivers/block/mtip32xx/mtip32xx.c @@ -2771,12 +2771,12 @@ static int mtip_service_thread(void *data) blk_mq_quiesce_queue(dd->queue); - blk_mq_tagset_busy_iter(&dd->tags, mtip_queue_cmd, dd); + blk_mq_queue_tag_inflight_iter(dd->queue, mtip_queue_cmd, dd); set_bit(MTIP_PF_ISSUE_CMDS_BIT, &dd->port->flags); if (mtip_device_reset(dd)) - blk_mq_tagset_busy_iter(&dd->tags, + blk_mq_queue_tag_inflight_iter(dd->queue, mtip_abort_cmd, dd); clear_bit(MTIP_PF_TO_ACTIVE_BIT, &dd->port->flags); @@ -3903,7 +3903,7 @@ static int mtip_block_remove(struct driver_data *dd) blk_freeze_queue_start(dd->queue); blk_mq_quiesce_queue(dd->queue); - blk_mq_tagset_busy_iter(&dd->tags, mtip_no_dev_cleanup, dd); + blk_mq_queue_tag_inflight_iter(dd->queue, mtip_no_dev_cleanup, dd); blk_mq_unquiesce_queue(dd->queue); /* -- 2.7.4