Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp2901928img; Sun, 24 Mar 2019 22:49:02 -0700 (PDT) X-Google-Smtp-Source: APXvYqyYa6xUUcg1MD0lHaF12YtrotkHW7GDaTC14CVXNOXw8n0ykjgm8SOmFNebx+rb2dH4rLee X-Received: by 2002:a17:902:e701:: with SMTP id co1mr23524237plb.61.1553492942342; Sun, 24 Mar 2019 22:49:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553492942; cv=none; d=google.com; s=arc-20160816; b=a/mwDgSA/N4PUVhb+xWPhE01XwpPjz9Ky4j0D3CJEo7G9WszM5aXdScqQDoKKbf7ee itY1hIPx9tR1QKkrB6ehc8uzcAL6s+eMpMw85bYNw5GMCAN9yGETJ7XDPnVgqqYWedwa bMqkRTvC8ZwZezbr/lnaivbN6NUCca4nHnLJzK4as4PaYR5z81asyhf9ruPEZzvSpC5E nwFbDJMJdnEyWdahil2MxB1Alq0tdOlaltwcrcEk7Tp+yy3aybjt/rgElphBWA3ohzYk e7Yht4s0X7+aVbJhyDmCD+SoxvTnGyJ0Fh/U8+2AKEjLFwy9wgC7pkNtiXyWhS563yMP 3B9A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from:dkim-signature; bh=7aA4xWq/tfGdYTPt4hOCXVnTHtj21qv2ydS8SKqRloY=; b=az6CIi48jeZ/7qUz/hcTEV/Lw85zVEZWO24wBrJb4KmJ/IOILFjSqNoA217X2OUtv5 /hKOVIDJutSr1+7o9dJEVmyEqhs3eGWMHSn+7GCnw4Klu9sMZBFucoPiQ+5sBxtjhHHL MQiApMMcoybHn1dUqtMRGB7311Y7y9eUW7yxJEK2inQv7PekPVbEEA1WUxNffqVlYZ+Y I3fQ2SkwsajyDmDK1zWAy5ARwT/O7hZaZ/Gi2mY+FPrXBFhod22+tYl0mK3YWNb+AIcb wWTCBAbWLytxv2ptga/dcp+pbzP4FtHZknJx+9I2HjXwsm9whWnI7b+xm5UB2FRsh3oh 9ZTA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=etRewFq+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id m15si12418672pgv.212.2019.03.24.22.48.47; Sun, 24 Mar 2019 22:49:02 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=etRewFq+; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729704AbfCYFry (ORCPT + 99 others); Mon, 25 Mar 2019 01:47:54 -0400 Received: from userp2130.oracle.com ([156.151.31.86]:56686 "EHLO userp2130.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729638AbfCYFri (ORCPT ); Mon, 25 Mar 2019 01:47:38 -0400 Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2P5i941004675; Mon, 25 Mar 2019 05:47:15 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=corp-2018-07-02; bh=7aA4xWq/tfGdYTPt4hOCXVnTHtj21qv2ydS8SKqRloY=; b=etRewFq+x35pGm5Lu6ZsLtmyb6FeFPNzlcRNwX3AIk3jseEGQbrfBrM2fETMwvzDyUez Bhdmd0/G3xhzMPQI/o9R6hjAorpdE4eOusyFUEgz3St9QsGUSIie/+cxaCeoceWZfh+7 v89lFb8G6lrhfXIscQx6bzK+jjuIEVaQ39e4YJGGntIqmtXapYS3OlZDrrBBS7oe6VNh UKHCcG3I5Yq00rwydeuXTS0NIIvOc3O2/nOn4/tvCjZ57uGKJWseh993Q9QN9Ahh1rCI 39ZuposM8Bl5mMSfLUZG5n4DG47oXuzHfLY99CAyTEtH8Pg/d5nihuJ4NEVx4s4v1P8a qw== Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2re6g0st4e-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Mar 2019 05:47:15 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2P5l9kO004834 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 Mar 2019 05:47:09 GMT Received: from abhmp0001.oracle.com (abhmp0001.oracle.com [141.146.116.7]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2P5l9j6026031; Mon, 25 Mar 2019 05:47:09 GMT Received: from will-ThinkCentre-M93p.cn.oracle.com (/10.182.71.12) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Sun, 24 Mar 2019 22:47:09 -0700 From: Jianchao Wang To: axboe@kernel.dk Cc: hch@lst.de, jthumshirn@suse.de, hare@suse.de, josef@toxicpanda.com, bvanassche@acm.org, sagi@grimberg.me, keith.busch@intel.com, jsmart2021@gmail.com, linux-block@vger.kernel.org, linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH V2 3/8] blk-mq: use blk_mq_queue_tag_inflight_iter in debugfs Date: Mon, 25 Mar 2019 13:38:33 +0800 Message-Id: <1553492318-1810-4-git-send-email-jianchao.w.wang@oracle.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1553492318-1810-1-git-send-email-jianchao.w.wang@oracle.com> References: <1553492318-1810-1-git-send-email-jianchao.w.wang@oracle.com> X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9205 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=1 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903250044 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org blk_mq_tagset_busy_iter is not safe that it could get stale request in tags->rqs[]. Use blk_mq_queue_tag_inflight_iter here. Signed-off-by: Jianchao Wang --- block/blk-mq-debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c index ec1d18c..b7f2538 100644 --- a/block/blk-mq-debugfs.c +++ b/block/blk-mq-debugfs.c @@ -438,7 +438,7 @@ static int hctx_busy_show(void *data, struct seq_file *m) struct blk_mq_hw_ctx *hctx = data; struct show_busy_params params = { .m = m, .hctx = hctx }; - blk_mq_tagset_busy_iter(hctx->queue->tag_set, hctx_show_busy_rq, + blk_mq_queue_tag_inflight_iter(hctx->queue, hctx_show_busy_rq, ¶ms); return 0; -- 2.7.4