Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Mar 2019 08:30:45 +0100
From:   Michal Kubecek <mkubecek@suse.cz>
To:     Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: regression (bisected): "modprobe parport_pc" hangs in current
 mainline
Message-ID: <20190325073045.GC26076@unicorn.suse.cz>
References: <20190313064557.GA14531@unicorn.suse.cz>
 <20190320211813.GE29968@unicorn.suse.cz>
 <CADVatmNVM3a=L6McdCsr5xzCwZnW6N4r9Cf55gjQZjsGGosBDg@mail.gmail.com>
 <1572645.oXzt2vILsi@alaris>
 <20190324193838.ubiljot22zhf5mjq@debian>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190324193838.ubiljot22zhf5mjq@debian>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, Mar 24, 2019 at 07:38:38PM +0000, Sudip Mukherjee wrote:
> And I was able to reproduce the problem using a vm and Suse Tumblewood with
> next-20190322. Can you please try the attached patch and test on your vm and
> machine and check if it fixes the problem.
> 
> --
> Regards
> Sudip

> diff --git a/drivers/parport/share.c b/drivers/parport/share.c
> index 0171b8dbcdcd..f87948fbfc34 100644
> --- a/drivers/parport/share.c
> +++ b/drivers/parport/share.c
> @@ -274,7 +274,7 @@ static int port_check(struct device *dev, void *dev_drv)
>  int __parport_register_driver(struct parport_driver *drv, struct module *owner,
>  			      const char *mod_name)
>  {
> -	if (list_empty(&portlist))
> +	if (list_empty(&portlist) && strcmp(drv->name, "daisy_drv"))
>  		get_lowlevel_driver();
>  
>  	if (drv->devmodel) {

Yes, with this patch (on top of v5.1-rc2), both physical machine and VM
let the module(s) load cleanly even with the alias line restored.

Tested-by: Michal Kubecek <mkubecek@suse.cz>

Thank you,
Michal