Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Mar 2019 08:53:51 +0100
From:   Borislav Petkov <bp@alien8.de>
To:     Baoquan He <bhe@redhat.com>
Cc:     Junichi Nomura <j-nomura@ce.jp.nec.com>,
        "fanc.fnst@cn.fujitsu.com" <fanc.fnst@cn.fujitsu.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86/boot: Use EFI setup data if provided
Message-ID: <20190325075342.GE12016@zn.tnic>
References: <20190322110342.GA16202@jeru.linux.bs1.fc.nec.co.jp>
 <20190322152328.GD12472@zn.tnic>
 <20190325072710.GA31828@MiWiFi-R3L-srv>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20190325072710.GA31828@MiWiFi-R3L-srv>
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 25, 2019 at 03:27:10PM +0800, Baoquan He wrote:
> Kexec kernel also need to get rsdp to get SRAT tables so that KASLR can
> avoid those hotpluggable regions in boot compression stage.
> 
> The kexec_file_load has filled in acpi_rsdp_addr of kexec kernel in
> below code. It will return direclty in get_rsdp_addr() since
> acpi_rsdp_addr is got from boot_params->acpi_rsdp_addr.
> 
> arch/x86/kernel/kexec-bzimage64.c <<setup_boot_parameters>>
> 	params->acpi_rsdp_addr = boot_params.acpi_rsdp_addr;
> 
> The other interface, kexec_load, its boot_params filling is done in user
> space kexec_tools. And we haven't made the acpi_rsdp_addr filling yet.
> And the old kexec_tools utility can also cause the new kexec kernel to
> search efi rspd pointer even thought it's fixed.

Yes, kexec is a pile of ugly and fragile hackery.

-- 
Regards/Gruss,
    Boris.

Good mailing practices for 400: avoid top-posting and trim the reply.