Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp2985498img; Mon, 25 Mar 2019 01:04:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqzlF2WM3NEjN3/huortaZfS7Gsi7Iq2G8EossnNmYN5QVewPl1YSd7yTdImNefnispJMSnp X-Received: by 2002:a63:2158:: with SMTP id s24mr13828970pgm.156.1553501086578; Mon, 25 Mar 2019 01:04:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553501086; cv=none; d=google.com; s=arc-20160816; b=m2nwq3dZjlebnbHAeDCqrA+va8hZ1zSIc8dxfAtsZt0461DgfMcV4pEW33Y39wdDV2 0kDFGE6JtZesUe3mBf4ICMwaDaRxboM8E/nSR4ght4buNI+OTGXCYqcqJhD0V5kvPcmn mVNnBMP7pWQQJladIkCDj1MMyP/8a1bZSeRWbRbJdbWFtjwfC9h6WXs2T2d/uk9/7NCD hm1r9xNc0VC2siD+Jt0lVCz9Ne11Ie2EqKjWcloMMJ9XbLEAx9sYDYcsHx8Qa3YfrD5k jFEG8sW4LSELLyaM6DH/j73gz5TEYrO+oydcWG+pA/nClJuKZQrhWj42mu97SMBWPSy4 BQ9w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=lWvWmAURjjyce2NukLttlZcwgP0aVZdUrz9ItXoLTJQ=; b=WRUGqd493nm7VLg3zoCC6cY4fvDKz4nwyApcf9xwfz7gp+R9XfJFBWJvk2PhDggDOu qX4O5YXkMVah7za+SQ87e93oO5UdXntGj54ZbLB4KjPXAqvUIwqGn9xCTU76qlSYuIOn QkbXOTxsJ3jRBJm9wn5VC7FQ11GrPurTfLvfrYOHb8hjMUoaykX+SqcSoVEOEUHE9DF8 d8kZqdTH3BgPDgw8F0vlwxRg8sbDXogkZv2/vYBtunbd5uMy2VF+v8MK8f1/tvs62pWT uMaSaXE2i5gkrGif45m+EuV06WC/sbZQf8rvbJND+1RdAkGkqA8vlGLr56hd1P8SVdnP 2SKw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q6si13308507pll.130.2019.03.25.01.04.30; Mon, 25 Mar 2019 01:04:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729917AbfCYIDu (ORCPT + 99 others); Mon, 25 Mar 2019 04:03:50 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:5746 "EHLO huawei.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729874AbfCYIDu (ORCPT ); Mon, 25 Mar 2019 04:03:50 -0400 Received: from DGGEMS402-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id BC1D8D8CD2BD9733582F; Mon, 25 Mar 2019 16:03:45 +0800 (CST) Received: from HGHY2Y004646261.china.huawei.com (10.184.12.158) by DGGEMS402-HUB.china.huawei.com (10.3.19.202) with Microsoft SMTP Server id 14.3.408.0; Mon, 25 Mar 2019 16:03:36 +0800 From: Zenghui Yu To: , CC: , , , , , , , Zenghui Yu Subject: [PATCH] KVM: arm/arm64: Comments cleanup in mmu.c Date: Mon, 25 Mar 2019 08:02:05 +0000 Message-ID: <1553500925-26000-1-git-send-email-yuzenghui@huawei.com> X-Mailer: git-send-email 2.6.4.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.184.12.158] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Some comments in virt/kvm/arm/mmu.c are outdated and incorrect. Get rid of these comments, to keep the code&comment correct and current as a whole. Only a cleanup here, no functional change. Signed-off-by: Zenghui Yu --- virt/kvm/arm/mmu.c | 23 +++++++++-------------- 1 file changed, 9 insertions(+), 14 deletions(-) diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c index ffd7acd..0a6efe7 100644 --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.c @@ -102,8 +102,7 @@ static bool kvm_is_device_pfn(unsigned long pfn) * @addr: IPA * @pmd: pmd pointer for IPA * - * Function clears a PMD entry, flushes addr 1st and 2nd stage TLBs. Marks all - * pages in the range dirty. + * Function clears a PMD entry, flushes addr 1st and 2nd stage TLBs. */ static void stage2_dissolve_pmd(struct kvm *kvm, phys_addr_t addr, pmd_t *pmd) { @@ -121,8 +120,7 @@ static void stage2_dissolve_pmd(struct kvm *kvm, phys_addr_t addr, pmd_t *pmd) * @addr: IPA * @pud: pud pointer for IPA * - * Function clears a PUD entry, flushes addr 1st and 2nd stage TLBs. Marks all - * pages in the range dirty. + * Function clears a PUD entry, flushes addr 1st and 2nd stage TLBs. */ static void stage2_dissolve_pud(struct kvm *kvm, phys_addr_t addr, pud_t *pudp) { @@ -899,9 +897,8 @@ int create_hyp_exec_mappings(phys_addr_t phys_addr, size_t size, * kvm_alloc_stage2_pgd - allocate level-1 table for stage-2 translation. * @kvm: The KVM struct pointer for the VM. * - * Allocates only the stage-2 HW PGD level table(s) (can support either full - * 40-bit input addresses or limited to 32-bit input addresses). Clears the - * allocated pages. + * Allocates only the stage-2 HW PGD level table(s) of size defined by + * stage2_pgd_size(kvm). * * Note we don't need locking here as this is only called when the VM is * created, which can only be done once. @@ -1451,13 +1448,11 @@ static void stage2_wp_pmds(struct kvm *kvm, pud_t *pud, } /** - * stage2_wp_puds - write protect PGD range - * @pgd: pointer to pgd entry - * @addr: range start address - * @end: range end address - * - * Process PUD entries, for a huge PUD we cause a panic. - */ + * stage2_wp_puds - write protect PGD range + * @pgd: pointer to pgd entry + * @addr: range start address + * @end: range end address + */ static void stage2_wp_puds(struct kvm *kvm, pgd_t *pgd, phys_addr_t addr, phys_addr_t end) { -- 1.8.3.1