Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH -next] drm/ttm: remove set but not used variable 'vgdev'
To:     David Airlie <airlied@linux.ie>, Gerd Hoffmann <kraxel@redhat.com>,
        <dri-devel@lists.freedesktop.org>,
        <virtualization@lists.linux-foundation.org>,
        <linux-kernel@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
References: <20190320020308.12745-1-yuehaibing@huawei.com>
 <20190325090212.GE2665@phenom.ffwll.local>
From:   YueHaibing <yuehaibing@huawei.com>
Message-ID: <2f723c57-fc9a-a4ee-271e-ff5d2f256fd3@huawei.com>
Date:   Mon, 25 Mar 2019 17:11:23 +0800
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.2.0
MIME-Version: 1.0
In-Reply-To: <20190325090212.GE2665@phenom.ffwll.local>
Content-Type: text/plain; charset="windows-1252"
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 2019/3/25 17:02, Daniel Vetter wrote:
> On Wed, Mar 20, 2019 at 02:03:08AM +0000, YueHaibing wrote:
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_init_mem_type':
>> drivers/gpu/drm/virtio/virtgpu_ttm.c:117:28: warning:
>>  variable 'vgdev' set but not used [-Wunused-but-set-variable]
>>
>> drivers/gpu/drm/virtio/virtgpu_ttm.c: In function 'virtio_gpu_bo_swap_notify':
>> drivers/gpu/drm/virtio/virtgpu_ttm.c:300:28: warning:
>>  variable 'vgdev' set but not used [-Wunused-but-set-variable]
>>
>> It is never used since introduction in dc5698e80cf7 ("Add virtio gpu driver.")
>>
>> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> 
> Subject prefix should be drm/virtio: which is maybe the reason Gerd hasn't
> spotted this yet.

Thanks, will fix it.

> -Daniel
> 
>> ---
>>  drivers/gpu/drm/virtio/virtgpu_ttm.c | 6 ------
>>  1 file changed, 6 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/virtio/virtgpu_ttm.c b/drivers/gpu/drm/virtio/virtgpu_ttm.c
>> index d6225ba20b30..eb007c2569d8 100644
>> --- a/drivers/gpu/drm/virtio/virtgpu_ttm.c
>> +++ b/drivers/gpu/drm/virtio/virtgpu_ttm.c
>> @@ -114,10 +114,6 @@ static const struct ttm_mem_type_manager_func virtio_gpu_bo_manager_func = {
>>  static int virtio_gpu_init_mem_type(struct ttm_bo_device *bdev, uint32_t type,
>>  				    struct ttm_mem_type_manager *man)
>>  {
>> -	struct virtio_gpu_device *vgdev;
>> -
>> -	vgdev = virtio_gpu_get_vgdev(bdev);
>> -
>>  	switch (type) {
>>  	case TTM_PL_SYSTEM:
>>  		/* System memory */
>> @@ -297,10 +293,8 @@ static void virtio_gpu_bo_move_notify(struct ttm_buffer_object *tbo,
>>  static void virtio_gpu_bo_swap_notify(struct ttm_buffer_object *tbo)
>>  {
>>  	struct virtio_gpu_object *bo;
>> -	struct virtio_gpu_device *vgdev;
>>  
>>  	bo = container_of(tbo, struct virtio_gpu_object, tbo);
>> -	vgdev = (struct virtio_gpu_device *)bo->gem_base.dev->dev_private;
>>  
>>  	if (bo->pages)
>>  		virtio_gpu_object_free_sg_table(bo);
>>
>>
>>
>