Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 5A7EA60767
Subject: Re: [PATCH] mfd: fix a potential NULL pointer dereference
To:     Lee Jones <lee.jones@linaro.org>, Kangjie Lu <kjlu@umn.edu>
Cc:     pakki001@umn.edu, linux-kernel@vger.kernel.org
References: <20190309080456.8579-1-kjlu@umn.edu>
 <C71F9E7E-5EF8-4AE5-92D4-4596D25B1D9B@umn.edu> <20190325075608.GY4731@dell>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <be967424-090f-d388-4530-47a9a817db1f@codeaurora.org>
Date:   Mon, 25 Mar 2019 14:43:25 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.0
MIME-Version: 1.0
In-Reply-To: <20190325075608.GY4731@dell>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 3/25/2019 1:26 PM, Lee Jones wrote:
> On Fri, 22 Mar 2019, Kangjie Lu wrote:
>
>> Hi Lee Jones,
>>
>> Can you review this patch?
> Don't poke.
>
> I have a very long list of reviews on my TODO.  Poking only surfaces
> your patch to the top of my Inbox, and since I review patches in
> reverse chronological order, it puts the review to the back of the
> queue.
>
>>> On Mar 9, 2019, at 2:04 AM, Kangjie Lu <kjlu@umn.edu> wrote:
>>>
>>> In case devm_kzalloc fails, the fix does NULL check and returns
>>> -ENOMEM upon failure so as to avoid NULL pointer dereference.
>>>
>>> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
>>> ---
>>> drivers/mfd/sm501.c | 3 +++
>>> 1 file changed, 3 insertions(+)
>>>
>>> diff --git a/drivers/mfd/sm501.c b/drivers/mfd/sm501.c
>>> index a530972c5a7e..e0173bf4b0dc 100644
>>> --- a/drivers/mfd/sm501.c
>>> +++ b/drivers/mfd/sm501.c
>>> @@ -1145,6 +1145,9 @@ static int sm501_register_gpio_i2c_instance(struct sm501_devdata *sm,
>>> 	lookup = devm_kzalloc(&pdev->dev,
>>> 			      sizeof(*lookup) + 3 * sizeof(struct gpiod_lookup),
>>> 			      GFP_KERNEL);
>>> +	if (!lookup)
>>> +		return -ENOMEM;

Seems you are using quite old codebase.
This patch is already there ..

https://elixir.bootlin.com/linux/v5.1-rc2/source/drivers/mfd/sm501.c#L1147

commit ae7b8eda27b3( mfd: sm501: Fix potential NULL pointer dereference )


Thanks,
Mukesh


>>> +
>>> 	lookup->dev_id = "i2c-gpio";
>>> 	if (iic->pin_sda < 32)
>>> 		lookup->table[0].chip_label = "SM501-LOW";