Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20190313064557.GA14531@unicorn.suse.cz> <20190320211813.GE29968@unicorn.suse.cz>
 <CADVatmNVM3a=L6McdCsr5xzCwZnW6N4r9Cf55gjQZjsGGosBDg@mail.gmail.com>
 <1572645.oXzt2vILsi@alaris> <20190324193838.ubiljot22zhf5mjq@debian> <20190325073045.GC26076@unicorn.suse.cz>
In-Reply-To: <20190325073045.GC26076@unicorn.suse.cz>
From:   Sudip Mukherjee <sudipm.mukherjee@gmail.com>
Date:   Mon, 25 Mar 2019 10:00:54 +0000
Message-ID: <CADVatmMX-HcORGXUdiBZn6hx4CAqZzyz_TGx=e0HwuPm-xoLsw@mail.gmail.com>
Subject: Re: regression (bisected): "modprobe parport_pc" hangs in current mainline
To:     Michal Kubecek <mkubecek@suse.cz>
Cc:     linux-kernel <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 25, 2019 at 7:30 AM Michal Kubecek <mkubecek@suse.cz> wrote:
>
> On Sun, Mar 24, 2019 at 07:38:38PM +0000, Sudip Mukherjee wrote:
> > And I was able to reproduce the problem using a vm and Suse Tumblewood with
> > next-20190322. Can you please try the attached patch and test on your vm and
> > machine and check if it fixes the problem.
> >
> > --
> > Regards
> > Sudip
>
> > diff --git a/drivers/parport/share.c b/drivers/parport/share.c
> > index 0171b8dbcdcd..f87948fbfc34 100644
> > --- a/drivers/parport/share.c
> > +++ b/drivers/parport/share.c
> > @@ -274,7 +274,7 @@ static int port_check(struct device *dev, void *dev_drv)
> >  int __parport_register_driver(struct parport_driver *drv, struct module *owner,
> >                             const char *mod_name)
> >  {
> > -     if (list_empty(&portlist))
> > +     if (list_empty(&portlist) && strcmp(drv->name, "daisy_drv"))
> >               get_lowlevel_driver();
> >
> >       if (drv->devmodel) {
>
> Yes, with this patch (on top of v5.1-rc2), both physical machine and VM
> let the module(s) load cleanly even with the alias line restored.
>
> Tested-by: Michal Kubecek <mkubecek@suse.cz>

Thanks Michal. I will add it to my queue with your Tested-by.

btw, I think I liked using Suse. :)


-- 
Regards
Sudip