Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp3076575img; Mon, 25 Mar 2019 03:19:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqxcr574hpwStXGuZQjksEF7NstmQSLn1EcTq7UmL+IxXhWsA+IZTJDzWDZpp6SSg+LHBwr6 X-Received: by 2002:a17:902:b58f:: with SMTP id a15mr10417711pls.36.1553509193729; Mon, 25 Mar 2019 03:19:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553509193; cv=none; d=google.com; s=arc-20160816; b=k6/o6xlGGN2FqepBSVNiP4/4M9KXOF/RHu9VN0rhstpH0lk3nEj2Qi5bN1C0SKUSF6 Qtq88FCOsOX5QU9aj3D+p8p9TO8Gi81CIH+sKGkvIZaBw2D8RyFnWKmr+bXThDGRSuxI m2/aTfaVDCr1AFWXDMBZUVaAztyZiDM8dqfqvGgLcd8hnj45+DoFBV+Ci7R1DXzBFGdM /sKpYBB191ILfqTru/j4nfUFMGgCd51+jsUH35YuTrwphJayQM+edf93yUHRmsk07n0Y Ni3KsZ1IG0pwEhKCCcdfYVFfxaIUE+XLddeSiNKEyBLuoP5lrpbsY04bLX6zbQW6pn8a IieQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:from:references:cc:to:subject; bh=fQA6C6GrE+G+0WEUXG+iAnXm6tTxAVmkm+Ztl637hog=; b=GsiOVCSd8lu0uyRBPwvQ5oB4PvB15rQaCGTjlo9pXxtH1thy5HDyHYc7MHa0WLqMVF cc8Rbf5CHW3mS1CS/v6CTlZQx9GlO2IlArtIV4ZJz6YnRLiETTPKfxzEB5FUKJv3oXPN yTVDVlJRAr2r7ZPUzZOlNAXBVUSDMAveL8wN6ID+Jpu0xrh3LQ7uiG7i9DM2/7huHau2 cyALKeRerTT7iTlT8CznztfaU44t6wEeHFQN39/ev1Z/gETIUrg5IDX5sP3QYZ7VBqA2 0/NSGHt5KaPg89o/kStoay1VOXzdZ6vo/G8/to2zpti6tYmNVr0R0JtjVd4iZAcmHj6E jGTg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b9si12661012pfd.228.2019.03.25.03.19.38; Mon, 25 Mar 2019 03:19:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730606AbfCYKS5 (ORCPT + 99 others); Mon, 25 Mar 2019 06:18:57 -0400 Received: from mga01.intel.com ([192.55.52.88]:33269 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730495AbfCYKS4 (ORCPT ); Mon, 25 Mar 2019 06:18:56 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Mar 2019 03:18:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,256,1549958400"; d="scan'208";a="134503543" Received: from ahunter-desktop.fi.intel.com (HELO [10.237.72.198]) ([10.237.72.198]) by fmsmga008.fm.intel.com with ESMTP; 25 Mar 2019 03:18:54 -0700 Subject: Re: [PATCH -next] mmc: sdhci-omap: Make sdhci_omap_reset static To: Yue Haibing , kishon@ti.com, ulf.hansson@linaro.org Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org References: <20190322141138.19244-1-yuehaibing@huawei.com> From: Adrian Hunter Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki, Business Identity Code: 0357606 - 4, Domiciled in Helsinki Message-ID: Date: Mon, 25 Mar 2019 12:17:38 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.0 MIME-Version: 1.0 In-Reply-To: <20190322141138.19244-1-yuehaibing@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/03/19 4:11 PM, Yue Haibing wrote: > From: YueHaibing > > Fix sparse warning: > > drivers/mmc/host/sdhci-omap.c:788:6: warning: > symbol 'sdhci_omap_reset' was not declared. Should it be static? > > Signed-off-by: YueHaibing Acked-by: Adrian Hunter > --- > drivers/mmc/host/sdhci-omap.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-omap.c b/drivers/mmc/host/sdhci-omap.c > index 5bbed47..649c03f 100644 > --- a/drivers/mmc/host/sdhci-omap.c > +++ b/drivers/mmc/host/sdhci-omap.c > @@ -785,7 +785,7 @@ static void sdhci_omap_set_uhs_signaling(struct sdhci_host *host, > sdhci_omap_start_clock(omap_host); > } > > -void sdhci_omap_reset(struct sdhci_host *host, u8 mask) > +static void sdhci_omap_reset(struct sdhci_host *host, u8 mask) > { > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > struct sdhci_omap_host *omap_host = sdhci_pltfm_priv(pltfm_host); >