Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Mar 2019 10:26:33 +0000
From:   Russell King - ARM Linux admin <linux@armlinux.org.uk>
To:     Peter Chen <hzpeterchen@gmail.com>
Cc:     Michal Nazarewicz <mina86@mina86.com>, peter.chen@nxp.com,
        fugang.duan@nxp.com, linux-usb@vger.kernel.org,
        lkml <linux-kernel@vger.kernel.org>, linux-mm@kvack.org,
        linux-arm-kernel@lists.infradead.org,
        Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: Why CMA allocater fails if there is a signal pending?
Message-ID: <20190325102633.v6hkvda6q7462wza@shell.armlinux.org.uk>
References: <CAL411-pwHq4Df-FsBu=Vzd4CR6Pzee2yR579hHeZuh8T7fBNJA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAL411-pwHq4Df-FsBu=Vzd4CR6Pzee2yR579hHeZuh8T7fBNJA@mail.gmail.com>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 25, 2019 at 04:37:09PM +0800, Peter Chen wrote:
> Hi Michal & Marek,
> 
> I meet an issue that the DMA (CMA used) allocation failed if there is a user
> signal, Eg Ctrl+C, it causes the USB xHCI stack fails to resume due to
> dma_alloc_coherent
> failed. It can be easy to reproduce if the user press Ctrl+C at
> suspend/resume test.

It has been possible in the past for cma_alloc() to take seconds or
longer to allocate, depending on the size of the CMA area and the
number of pinned GFP_MOVABLE pages within the CMA area.  Whether that
is true of today's CMA or not, I don't know.

It's probably there to allow such a situation to be recoverable, but
is not a good idea if we're expecting dma_alloc_*() not to fail in
those scenarios.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up