Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v0] nvmem: core: Export nvmem cell info to userspace
To:     Gaurav Kohli <gkohli@codeaurora.org>, linux-kernel@vger.kernel.org
Cc:     linux-arm-msm@vger.kernel.org,
        Shiraz Hashim <shashim@codeaurora.org>
References: <1553061201-28894-1-git-send-email-gkohli@codeaurora.org>
 <b356f99c-15ff-06ce-e40b-4bb8b664b6c9@linaro.org>
 <ecd3986a-7846-1f87-4d2e-4c66bd6698c9@codeaurora.org>
From:   Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Message-ID: <f6a9162f-4d91-1ef4-db9c-deb763cf5778@linaro.org>
Date:   Mon, 25 Mar 2019 10:58:38 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <ecd3986a-7846-1f87-4d2e-4c66bd6698c9@codeaurora.org>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 24/03/2019 15:25, Gaurav Kohli wrote:
> 
> On 3/22/2019 8:53 PM, Srinivas Kandagatla wrote:
>>
>>
>> On 20/03/2019 05:53, Gaurav Kohli wrote:
>>> From: Shiraz Hashim <shashim@codeaurora.org>
>>>
>>> Existing nvmem framework export full register space
>>> as nvmem binary, but not exporting child node of nvmem
>>> which is nvmem cell. Kernel can read the specific cell
>>> by using nvmem_cell_read but userspace don't have such
>>> provision.
>>>
>>> Add framework to export nvmem cell as well, So
>>> userspace can use it directly.
>>>
>>> Signed-off-by: Shiraz Hashim <shashim@codeaurora.org>
>>> Signed-off-by: Gaurav Kohli <gkohli@codeaurora.org>
>>> Co-developed-by: Gaurav Kohli <gkohli@codeaurora.org>
>>>
>>> diff --git a/drivers/nvmem/core.c b/drivers/nvmem/core.c
>>
>> Thankyou for the patch.
>>
>> Why do you need such provision when the userspace can just get the 
>> cell values using correct offset and size.
>> This will also bring over head of managing entries dynamically + 
>> confusing userspace abi.
>>
>> Unless you have a valid reason or usecase I don't see the need for this.
> 
> 
> Hi Srinivas,
> 
> 
> This is mainly for user space convenience, In existing implementation 
> they have to do manipulation according

> 
> to offset and bit, And with present patch, they just have to do cat for 
> cell name and which can also be easily maintainable
Yes, that is expected I guess!

> 
> for different soc. But with current, it is difficult to maintain users 
> space code as each time we have to change user space code according to bit.

Which user space code/application are you referring to here? Are these 
open source?

> 
> 
> This would also help to expose certain bit only as per the bit parameter 
> mentioned in dt node, which would also help to protect exposing of
> 
NVMEM is not just limited for DT users, non dt users use this f/w too.
So the problem is not as simple as it sounds.

If your issue is just about DT, you could easily parse active device 
tree via  /proc/device-tree and get cell offset, length and names from 
it, use this information to read from nvmem.

There are other concerns about the userspace ABI w.r.t udev events.
udev events would race with the creation on this cell entries resulting 
in a behavior where user-space applications would not see the entries 
after udev events.

In worst case if we decide to go with adding cells to nvmem then we 
should do it before the device is even probed using group attributes.
And this would mean that we can not support cells that are dynamically 
defined. And there might be some memory freeing issues in this method too!

--srini


> other bits to user space.
> 
>>
>> thanks,
>> srini
>