Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH v4 1/2] Bluetooth: hci_qca: Added support for WCN3998
To:     Harish Bandi <c-hbandi@codeaurora.org>
References: <1553513491-25763-1-git-send-email-c-hbandi@codeaurora.org>
 <1553513491-25763-2-git-send-email-c-hbandi@codeaurora.org>
Cc:     MSM <linux-arm-msm@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Matthias Kaehlcke <mka@chromium.org>
From:   Marc Gonzalez <marc.w.gonzalez@free.fr>
Message-ID: <e17eb2d2-8d32-70c6-32f9-435671233bfc@free.fr>
Date:   Mon, 25 Mar 2019 12:49:48 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <1553513491-25763-2-git-send-email-c-hbandi@codeaurora.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 25/03/2019 12:31, Harish Bandi wrote:

> +bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type)
> +{
> +	if ((soc_type  == QCA_WCN3990) || (soc_type  == QCA_WCN3998))
                      ^                             ^
            spurious white-space               here as well

> +		return true;
> +
> +	return false;
> +}

(Apologies for the bike-shed)

I don't know what the kernel coding-style says about this, but for
functions returning bool, isn't it better to write

	return $BOOLEAN_EXPRESSION;

instead of

	if ($BOOLEAN_EXPRESSION)
		return true;
	return false;

i.e.

bool is_qca_soc_type_wcn399x_family(enum qca_btsoc_type soc_type)
{
	return soc_type == QCA_WCN3990 || soc_type  == QCA_WCN3998;
}

Regards.