Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Mar 2019 10:15:15 -0400 (EDT)
From:   Alan Stern <stern@rowland.harvard.edu>
To:     Kangjie Lu <kjlu@umn.edu>
cc:     pakki001@umn.edu, Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        <linux-usb@vger.kernel.org>,
        <usb-storage@lists.one-eyed-alien.net>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] usb: sierra: fix a missing check of device_create_file
In-Reply-To: <20190325030828.14068-1-kjlu@umn.edu>
Message-ID: <Pine.LNX.4.44L0.1903251013140.1485-100000@iolanthe.rowland.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Sun, 24 Mar 2019, Kangjie Lu wrote:

> device_create_file() could fail and return an error code. The fix
> captures the error and returns the error code upstream in case it
> indeed failed.
> 
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>  drivers/usb/storage/sierra_ms.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/usb/storage/sierra_ms.c b/drivers/usb/storage/sierra_ms.c
> index 6ac60abd2e15..e605cbc3d8bf 100644
> --- a/drivers/usb/storage/sierra_ms.c
> +++ b/drivers/usb/storage/sierra_ms.c
> @@ -194,8 +194,6 @@ int sierra_ms_init(struct us_data *us)
>  		kfree(swocInfo);
>  	}
>  complete:
> -	result = device_create_file(&us->pusb_intf->dev, &dev_attr_truinst);
> -
> -	return 0;
> +	return device_create_file(&us->pusb_intf->dev, &dev_attr_truinst);
>  }

Acked-by: Alan Stern <stern@rowland.harvard.edu>

It's possible the original author intended the function to succeed even 
if device_create_file() failed, since the information in the file 
doesn't seem to be very important.  However, I will accept the patch.

Alan Stern