Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp3308418img; Mon, 25 Mar 2019 07:48:15 -0700 (PDT) X-Google-Smtp-Source: APXvYqxR2nXDe9D3WIXXwxiGRx4v42BZTUVqJDnoyDZlw8/7yyKzYWcEBtToHTlUF7mQzM+3HFhm X-Received: by 2002:a17:902:aa90:: with SMTP id d16mr24859313plr.250.1553525295604; Mon, 25 Mar 2019 07:48:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553525295; cv=none; d=google.com; s=arc-20160816; b=qMlXq+/E5+S1wajqNOh6gOplSzQtizM7bgHrVIfqwYpqfcZx2pnQiCSA6+/RQvy14M KcS4R/Bv8cR2DBSaFiUiLjH+JFaZuvxHvnJETd60VfXWHGy1GsTRRzuQmYq/2HxRm15f lg70fXiImkcun2djphDO7D9auFknwC0qcn78Yd76UNC+jR0553/TdhNArgH17T1m6KmF Fgfs7c2DePyLNri4eBUaYtIBn6nyVn5YthYZgnZTY1nfF7uwA+VwxqNLEQZdpM4ei1GZ odbu4/NMthsYVZ0DJ+G0vRu7sCkTTo4ppCbc+rl22fzUBr1IypzYjNMSaElywgDVMGqH guyw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:message-id:date:subject:cc :to:from; bh=ALapYYi3X/2aajIIkYD2vsbmx+p0YVsR8VUiDHDCtGI=; b=DSO+WzmPkp0d2wUiNDr3u7r/UxEJOW5oHiKC6Xxot+I/CWI687bk2ny/ITl7yU88uF U1SK3VClZ9E3Ss7e8jawSPtzFIEzWU5MD1lncUzvoOrbSKHsUMSsB7popFeQXSMM06od lg3edbe3JTsYW3d4tbNTtnkEfPsUQG0HPsGeBMDi3rR7HYY1dZtdpMClHTGfnaEvjA+l 5igvIhK/othiCTbaXWrXE1fmeel20THmk9hxT1fSszQCR/2gGrwUqrnJW4LCf+bnmS0T IltJWLr89w/YXuH+52rQSj8qcfUgAWmjFygFAkJ4lMs50n1og9awSAd+yC+NO16NXPUv d0Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id t17si6069829pfe.250.2019.03.25.07.48.00; Mon, 25 Mar 2019 07:48:15 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729095AbfCYOrC (ORCPT + 99 others); Mon, 25 Mar 2019 10:47:02 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:58189 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726128AbfCYOrB (ORCPT ); Mon, 25 Mar 2019 10:47:01 -0400 Received: from pps.filterd (m0046661.ppops.net [127.0.0.1]) by mx08-00178001.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x2PEk8Op012737; Mon, 25 Mar 2019 15:46:29 +0100 Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx08-00178001.pphosted.com with ESMTP id 2rddhaca9d-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Mon, 25 Mar 2019 15:46:29 +0100 Received: from zeta.dmz-eu.st.com (zeta.dmz-eu.st.com [164.129.230.9]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 6F3EB3D; Mon, 25 Mar 2019 14:46:28 +0000 (GMT) Received: from Webmail-eu.st.com (sfhdag5node2.st.com [10.75.127.14]) by zeta.dmz-eu.st.com (STMicroelectronics) with ESMTP id 520EDA657; Mon, 25 Mar 2019 14:46:28 +0000 (GMT) Received: from localhost (10.75.127.45) by SFHDAG5NODE2.st.com (10.75.127.14) with Microsoft SMTP Server (TLS) id 15.0.1347.2; Mon, 25 Mar 2019 15:46:27 +0100 From: Pierre-Yves MORDRET To: Dan Williams , Vinod Koul , Maxime Coquelin , Alexandre Torgue , , , , CC: Pierre-Yves MORDRET Subject: [PATCH v1] Revert "dmaengine: stm32-mdma: Add a check on read_u32_array" Date: Mon, 25 Mar 2019 15:46:27 +0100 Message-ID: <1553525187-13533-1-git-send-email-pierre-yves.mordret@st.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.75.127.45] X-ClientProxiedBy: SFHDAG6NODE2.st.com (10.75.127.17) To SFHDAG5NODE2.st.com (10.75.127.14) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2019-03-25_09:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org This reverts commit 906b40b246b0acb54c4dc97e815cf734761c9820. As stated by bindings "st,ahb-addr-masks" is optional. The statement inserted by this commit makes this property mandatory and prevents MDMA to be probed in case property not present. Signed-off-by: Pierre-Yves MORDRET --- drivers/dma/stm32-mdma.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/dma/stm32-mdma.c b/drivers/dma/stm32-mdma.c index 4e0eede..ac0301b 100644 --- a/drivers/dma/stm32-mdma.c +++ b/drivers/dma/stm32-mdma.c @@ -1578,11 +1578,9 @@ static int stm32_mdma_probe(struct platform_device *pdev) dmadev->nr_channels = nr_channels; dmadev->nr_requests = nr_requests; - ret = device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", + device_property_read_u32_array(&pdev->dev, "st,ahb-addr-masks", dmadev->ahb_addr_masks, count); - if (ret) - return ret; dmadev->nr_ahb_addr_masks = count; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); -- 2.7.4