Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 25 Mar 2019 17:01:42 +0200
From:   Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To:     Thomas Preston <thomas.preston@codethink.co.uk>
Cc:     "Rafael J. Wysocki" <rafael@kernel.org>,
        Mika Westerberg <mika.westerberg@linux.intel.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Documentation: acpi: Add an example for PRP0001
Message-ID: <20190325150142.GE9224@smile.fi.intel.com>
References: <20190322134705.27994-1-thomas.preston@codethink.co.uk>
 <CAJZ5v0isa7x+XPAregcKtMxtgsNw43JuBhGB_1x3eHkvaV8HRg@mail.gmail.com>
 <20190325115118.GP9224@smile.fi.intel.com>
 <20190325130413.GT9224@smile.fi.intel.com>
 <d67bb260-863c-1131-1323-711c3d2e227d@codethink.co.uk>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <d67bb260-863c-1131-1323-711c3d2e227d@codethink.co.uk>
Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
User-Agent: Mutt/1.10.1 (2018-07-13)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Mar 25, 2019 at 02:42:09PM +0000, Thomas Preston wrote:
> On 25/03/2019 13:04, Andy Shevchenko wrote:
> > On Mon, Mar 25, 2019 at 01:51:18PM +0200, Andy Shevchenko wrote:
> > > On Mon, Mar 25, 2019 at 10:31:13AM +0100, Rafael J. Wysocki wrote:

> > > Though one thing I would like to add (not directly related to the patch
> > > per se), i.e. it would be nice to keep such examples under meta-acpi [1]
> > > umbrella as a database for such excerpts.
> > > 
> > > Thomas, can you do that?
> > > 
> > > [1]: https://github.com/westeri/meta-acpi
> 
> I will :)

Thank you! I will take either GH PR, or you may send an email to maintainers,
i.e. Mika and me (PR is preferable because it would be seen publicly)

> > > > > +               Name (_HID, "TITMP75") /* _HID will appear in sysfs */
> > 
> > Sorry for not noticing earlier.
> > 
> > Is this an official ID for the chip? We discourage people to invent ACPI IDs on
> > their own.

> The device is a TI tmp75b temperature sensor [0]. The HID is completely
> made up, I'm afraid. It doesn't exist in the registry.

Thanks for clarification. In that case I would rather recommend to use simple
PRP0001 as a _HID.

> [0] http://www.ti.com/lit/ds/symlink/tmp75b.pdf

-- 
With Best Regards,
Andy Shevchenko