Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1553530847.6114.0.camel@gmail.com>
Subject: Re: dell_smbios KASAN bug
From:   Tom Zanussi <tzanussi@gmail.com>
To:     Steven Rostedt <rostedt@goodmis.org>, Mario.Limonciello@dell.com
Cc:     pali.rohar@gmail.com, linux-kernel@vger.kernel.org
Date:   Mon, 25 Mar 2019 11:20:47 -0500
In-Reply-To: <20190325101731.3558ecda@gandalf.local.home>
References: <1553106560.2080.5.camel@gmail.com>
         <20190320144146.08ecd5e4@gandalf.local.home>
         <1553108749.2079.1.camel@gmail.com>
         <20190320151353.1a223c0e@gandalf.local.home>
         <9541737623f942e49e9310aef963ffbf@ausx13mpc120.AMER.DELL.COM>
         <20190325101731.3558ecda@gandalf.local.home>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Steve,

On Mon, 2019-03-25 at 10:17 -0400, Steven Rostedt wrote:
> On Mon, 25 Mar 2019 13:22:35 +0000
> <Mario.Limonciello@dell.com> wrote:
> 
> > > diff --git a/drivers/platform/x86/dell-smbios-base.c
> > > b/drivers/platform/x86/dell-
> > > smbios-base.c
> > > index 9dc282ed5a9e..c3825c674522 100644
> > > --- a/drivers/platform/x86/dell-smbios-base.c
> > > +++ b/drivers/platform/x86/dell-smbios-base.c
> > > @@ -619,6 +619,7 @@ static int __init dell_smbios_init(void)
> > > 
> > >  fail_platform_driver:
> > >  	kfree(da_tokens);
> > > +	da_num_tokens = 0;
> > >  	return ret;
> > >  }
> > >   
> > 
> > Steven,
> > 
> > Since Tom confirmed this works will you send a formal patch to the
> > ML with this fix?
> 
> Will do.
> 
> Tom,
> 
> Is it OK if I add the following tags to that patch?
> 
> Reported-by: Tom Zanussi <tzanussi@gmail.com>
> Tested-by: Tom Zanussi <tzanussi@gmail.com>
> 

Yep, fine with me.

Tom

> -- Steve