Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp3404471img; Mon, 25 Mar 2019 09:35:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqzJFZCEmb9yZoAOIGO4vc7uKTHlg10XAgxdKQRFwzN54npsGKTu8NiomJ4Nmh+OPmGkO9lD X-Received: by 2002:a62:6383:: with SMTP id x125mr24170997pfb.239.1553531737093; Mon, 25 Mar 2019 09:35:37 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553531737; cv=none; d=google.com; s=arc-20160816; b=z903mMHWiPbmhb8lGF7Obo2HLMY/d34aTKqYjhrAtu1e6Udeufcnt868z60lXHOHKG CC4ALeELR/n9yzMmWbBIkgk/Y9zFSGMEj/Qe32McBQXA4oJ87+w9yYs09XyHkmGa/GqK qtOgeK1M13B7Bdi6xQsMOIseZiAM7WlRXKw+6YaAnDy2a1nNlLlkx9d7L2hdJrMh6E5i irOVJPvvEvJL+mfRWjp36r1eq9j0EUTlkamfyK6LoFzsX6cePWRtN7vf7x5kc34bDf+N gQb79nG6bogsIPe+R5/KJC7Hxvhjqp28odE4qz0nkclhizQOY/CwLPyEjXwS3nDqvZhJ z6uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :reply-to:message-id:subject:cc:to:from:date; bh=qA86w4KQbsYb9nFPrGJ1fMKbSarvjqrg3cItg7lllWk=; b=k1hekqMZ27er05zzFmkW78+RDep+FJJE8md3THmA4aS7KKb/iNi7IiCSR26pUctaq4 eHfDV4xshGMJEVd9BIZwDD4RQ/xjn+A/fEWvf/uYxaTSr0W/uaZbelEwZju+tL3rmmsS G120b1ZkdpMRKdMfDi7CQNjDgQdQf0+IBGLd/OjNjiblGXMpTExT4E+3MJdyOiZ9JziZ JJCLSn5sU8O7PzX5/paHaF0h3xMWTMqRHqJHy6uImJAZK/lw/KnW+rEId6c2wRYIOTv/ fevUzybRoihjJHYGEooJKdgmJmgLjPO5tQIXUt5UV0/VH+h5jOPpYxiumAu9rHwnI9nw f7xw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k75si5487796pgc.515.2019.03.25.09.35.21; Mon, 25 Mar 2019 09:35:37 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729819AbfCYQec (ORCPT + 99 others); Mon, 25 Mar 2019 12:34:32 -0400 Received: from mx2.suse.de ([195.135.220.15]:44584 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1729095AbfCYQe1 (ORCPT ); Mon, 25 Mar 2019 12:34:27 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id D3CE0AC3C; Mon, 25 Mar 2019 16:34:25 +0000 (UTC) Received: by ds.suse.cz (Postfix, from userid 10065) id C2498DA825; Mon, 25 Mar 2019 17:35:38 +0100 (CET) Date: Mon, 25 Mar 2019 17:35:38 +0100 From: David Sterba To: Kangjie Lu Cc: pakki001@umn.edu, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] btrfs: fix a NULL pointer dereference Message-ID: <20190325163538.GK10640@twin.jikos.cz> Reply-To: dsterba@suse.cz Mail-Followup-To: dsterba@suse.cz, Kangjie Lu , pakki001@umn.edu, Chris Mason , Josef Bacik , David Sterba , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org References: <20190314075041.28966-1-kjlu@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190314075041.28966-1-kjlu@umn.edu> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 14, 2019 at 02:50:40AM -0500, Kangjie Lu wrote: > btrfs_lookup_block_group may fail and return NULL. The fix goes > to out when it fails to avoid NULL pointer dereference. The subject, changelog and code change are not valid anymore after the discussion. Please update them accordingly and resend. Thanks.