Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [RFC PATCH] mm: readahead: add readahead_shift into backing
 device
To:     Fengguang Wu <fengguang.wu@intel.com>,
        Martin Liu <liumartin@google.com>
Cc:     akpm@linux-foundation.org, axboe@kernel.dk, dchinner@redhat.com,
        jenhaochen@google.com, salyzyn@google.com, linux-mm@kvack.org,
        linux-kernel@vger.kernel.org, linux-block@vger.kernel.org
References: <20190322154610.164564-1-liumartin@google.com>
 <20190325121628.zxlogz52go6k36on@wfg-t540p.sh.intel.com>
From:   Mark Salyzyn <salyzyn@android.com>
Message-ID: <9b194e61-f2d0-82cb-30ac-95afb493b894@android.com>
Date:   Mon, 25 Mar 2019 09:59:31 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190325121628.zxlogz52go6k36on@wfg-t540p.sh.intel.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-GB
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 03/25/2019 05:16 AM, Fengguang Wu wrote:
> Martin,
>
> On Fri, Mar 22, 2019 at 11:46:11PM +0800, Martin Liu wrote:
>> As the discussion https://lore.kernel.org/patchwork/patch/334982/
>> We know an open file's ra_pages might run out of sync from
>> bdi.ra_pages since sequential, random or error read. Current design
>> is we have to ask users to reopen the file or use fdavise system
>> call to get it sync. However, we might have some cases to change
>> system wide file ra_pages to enhance system performance such as
>> enhance the boot time by increasing the ra_pages or decrease it to
>
> Do you have examples that some distro making use of larger ra_pages
> for boot time optimization?

Android (if you are willing to squint and look at android-common AOSP 
kernels as a Distro).

>
> Suppose N read streams with equal read speed. The thrash-free memory
> requirement would be (N * 2 * ra_pages).
>
> If N=1000 and ra_pages=1MB, it'd require 2GB memory. Which looks
> affordable in mainstream servers.
That is 50% of the memory on a high end Android device ...
>
> Sorry but it sounds like introducing an unnecessarily twisted new
> interface. I'm afraid it fixes the pain for 0.001% users while
> bringing more puzzle to the majority others.
 >2B Android devices on the planet is 0.001%?

I am not defending the proposed interface though, if there is something 
better that can be used, then looking into:
>
> Then let fadvise() and shrink_readahead_size_eio() adjust that
> per-file ra_pages_shift.
Sounds like this would require a lot from init to globally audit and 
reduce the read-ahead for all open files?

Sincerely -- Mark Salyzyn