Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Ghannam, Yazen" <Yazen.Ghannam@amd.com>
To:     "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
CC:     "Ghannam, Yazen" <Yazen.Ghannam@amd.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "lenb@kernel.org" <lenb@kernel.org>
Subject: [PATCH] tools/power turbostat: Make interval calculation per thread
 to reduce jitter
Thread-Topic: [PATCH] tools/power turbostat: Make interval calculation per
 thread to reduce jitter
Thread-Index: AQHU4zDAw6kMdRt2pEeSvDZqbzvAVQ==
Date:   Mon, 25 Mar 2019 17:32:42 +0000
Message-ID: <20190325173232.216357-1-Yazen.Ghannam@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: git-send-email 2.17.1
x-originating-ip: [165.204.78.1]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: ea406879-15c6-4f98-3125-08d6b147e2c7
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:SN6PR12MB2782;
x-ms-traffictypediagnostic: SN6PR12MB2782:
x-microsoft-antispam-prvs: <SN6PR12MB27821F2ED9E351FEFE168EB8F85E0@SN6PR12MB2782.namprd12.prod.outlook.com>
x-forefront-prvs: 0987ACA2E2
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(366004)(346002)(39860400002)(396003)(136003)(376002)(199004)(189003)(81156014)(53936002)(316002)(305945005)(7736002)(8676002)(54906003)(81166006)(8936002)(4326008)(66066001)(6916009)(68736007)(386003)(99286004)(97736004)(72206003)(71200400001)(478600001)(50226002)(106356001)(14454004)(105586002)(2351001)(71190400001)(2501003)(5660300002)(14444005)(256004)(1076003)(486006)(25786009)(2616005)(476003)(86362001)(36756003)(6512007)(6436002)(6486002)(2906002)(6116002)(3846002)(186003)(102836004)(26005)(52116002)(5640700003)(6506007);DIR:OUT;SFP:1101;SCL:1;SRVR:SN6PR12MB2782;H:SN6PR12MB2639.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:3;MX:1;
received-spf: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: Q1ZsdjZ1GL/MDmrL8BEeGFS1IppEusS1l47pc+I4tSf/2gpukHOq/bidSMLDrKSMXoBuMKSt9vob5Ofo5PxsKnYD2BG8UCj+04yOBcvj/WdI/N6VZUE4egW0ScIypM4sA1TVkbebovBscunBNB8fUeIxwsXZCdkMLC4eKJD0D/q8zC8Xa2s8K4a1BxBKOBWvoYs0h/wa4TXZYZG3QzD5iD2xy1lUm1yT+3AAF68SHI+l2LbB7mLvOyJSnGR/+msDOVZjWo9Da+cqPcAhJBsxhF3y0v5R1xWg40ejdtR8vzmwmbazY6TDTCwveK6cC6M/WJBtDd0hPO6wq/DODrRftcl0Vlc5YOMwizaD48q20DoEa22w0eZrIkVXxu5IUZhRXx58uhXmZSjVQa1/mSx5AOtTIkvupRgS7jW6QedtToM=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ea406879-15c6-4f98-3125-08d6b147e2c7
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2019 17:32:42.7665
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR12MB2782
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

From: Yazen Ghannam <yazen.ghannam@amd.com>

Turbostat currently normalizes TSC and other values by dividing by an
interval. This interval is the delta between the start of one global
(all counters on all CPUs) sampling and the start of another. However,
this introduces a lot of jitter into the data.

In order to reduce jitter, the interval calculation should be based on
timestamps taken per thread and close to the start of the thread's
sampling.

Define a per thread time value to hold the delta between samples taken
on the thread.

Use the timestamp taken at the beginning of sampling to calculate the
delta.

Move the thread's beginning timestamp to after the CPU migration to
avoid jitter due to the migration.

Use the global time delta for the average time delta.

Signed-off-by: Yazen Ghannam <yazen.ghannam@amd.com>
---
 tools/power/x86/turbostat/turbostat.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/tools/power/x86/turbostat/turbostat.c b/tools/power/x86/turbos=
tat/turbostat.c
index c3fad065c89c..6ebcc420021f 100644
--- a/tools/power/x86/turbostat/turbostat.c
+++ b/tools/power/x86/turbostat/turbostat.c
@@ -166,6 +166,7 @@ size_t cpu_present_setsize, cpu_affinity_setsize, cpu_s=
ubset_size;
 struct thread_data {
 	struct timeval tv_begin;
 	struct timeval tv_end;
+	struct timeval tv_delta;
 	unsigned long long tsc;
 	unsigned long long aperf;
 	unsigned long long mperf;
@@ -896,7 +897,7 @@ int format_counters(struct thread_data *t, struct core_=
data *c,
 	if (DO_BIC(BIC_TOD))
 		outp +=3D sprintf(outp, "%10ld.%06ld\t", t->tv_end.tv_sec, t->tv_end.tv_=
usec);
=20
-	interval_float =3D tv_delta.tv_sec + tv_delta.tv_usec/1000000.0;
+	interval_float =3D t->tv_delta.tv_sec + t->tv_delta.tv_usec/1000000.0;
=20
 	tsc =3D t->tsc * tsc_tweak;
=20
@@ -1279,6 +1280,7 @@ delta_thread(struct thread_data *new, struct thread_d=
ata *old,
 	 * over-write old w/ new so we can print end of interval values
 	 */
=20
+	timersub(&new->tv_begin, &old->tv_begin, &old->tv_delta);
 	old->tv_begin =3D new->tv_begin;
 	old->tv_end =3D new->tv_end;
=20
@@ -1374,6 +1376,8 @@ void clear_counters(struct thread_data *t, struct cor=
e_data *c, struct pkg_data
 	t->tv_begin.tv_usec =3D 0;
 	t->tv_end.tv_sec =3D 0;
 	t->tv_end.tv_usec =3D 0;
+	t->tv_delta.tv_sec =3D 0;
+	t->tv_delta.tv_usec =3D 0;
=20
 	t->tsc =3D 0;
 	t->aperf =3D 0;
@@ -1540,6 +1544,9 @@ void compute_average(struct thread_data *t, struct co=
re_data *c,
=20
 	for_all_cpus(sum_counters, t, c, p);
=20
+	/* Use the global time delta for the average. */
+	average.threads.tv_delta =3D tv_delta;
+
 	average.threads.tsc /=3D topo.num_cpus;
 	average.threads.aperf /=3D topo.num_cpus;
 	average.threads.mperf /=3D topo.num_cpus;
@@ -1729,13 +1736,13 @@ int get_counters(struct thread_data *t, struct core=
_data *c, struct pkg_data *p)
 	struct msr_counter *mp;
 	int i;
=20
-	gettimeofday(&t->tv_begin, (struct timezone *)NULL);
-
 	if (cpu_migrate(cpu)) {
 		fprintf(outf, "Could not migrate to CPU %d\n", cpu);
 		return -1;
 	}
=20
+	gettimeofday(&t->tv_begin, (struct timezone *)NULL);
+
 	if (first_counter_read)
 		get_apic_id(t);
 retry:
--=20
2.17.1