Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <4faf234df19c1b54b70cbe82c0dacacc58568b87.camel@perches.com>
Subject: Re: [PATCH] vfio: Use dev_printk() when possible
From:   Joe Perches <joe@perches.com>
To:     Bjorn Helgaas <helgaas@kernel.org>,
        Alex Williamson <alex.williamson@redhat.com>
Cc:     kvm@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bjorn Helgaas <bhelgaas@google.com>
Date:   Mon, 25 Mar 2019 13:49:25 -0700
In-Reply-To: <20190325194220.5873-1-helgaas@kernel.org>
References: <20190325194220.5873-1-helgaas@kernel.org>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.30.1-1build1 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-03-25 at 14:42 -0500, Bjorn Helgaas wrote:
> Use dev_printk() when possible to make messages consistent with other
> device-related messages.

trivial note:

> diff --git a/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c b/drivers/vfio/platform/reset/vfio_platform_amdxgbe.c
[]
> @@ -89,7 +89,8 @@ static int vfio_platform_amdxgbe_reset(struct vfio_platform_device *vdev)
>  	} while ((pcs_value & MDIO_CTRL1_RESET) && --count);
>  
>  	if (pcs_value & MDIO_CTRL1_RESET)
> -		pr_warn("%s XGBE PHY reset timeout\n", __func__);
> +		dev_warn(&vdev->device, "%s XGBE PHY reset timeout\n",
> +			 __func__);

Many of these could use a colon after the %s used with __func__
to make the output more consistent with other modules.