Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Parav Pandit <parav@mellanox.com>
To:     Alex Williamson <alex.williamson@redhat.com>,
        Kirti Wankhede <kwankhede@nvidia.com>
CC:     "kvm@vger.kernel.org" <kvm@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/8] vfio/mdev: Fix to not do put_device on
 device_register failure
Thread-Topic: [PATCH 1/8] vfio/mdev: Fix to not do put_device on
 device_register failure
Thread-Index: AQHU4QX8efp2y+k+mUSt3U8lp+tcVaYcq/gAgAAR3oCAAB6vMA==
Date:   Mon, 25 Mar 2019 21:11:58 +0000
Message-ID: <VI1PR0501MB2271463ABA9D5D208E7F68B5D15E0@VI1PR0501MB2271.eurprd05.prod.outlook.com>
References: <1553296835-37522-1-git-send-email-parav@mellanox.com>
        <1553296835-37522-2-git-send-email-parav@mellanox.com>
        <2c096714-74cd-48ff-496f-b3919990e3e5@nvidia.com>
 <20190325132127.7430864b@x1.home>
In-Reply-To: <20190325132127.7430864b@x1.home>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: mellanox.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 22141de8-91f6-4ecc-2567-08d6b1668439
X-MS-Exchange-CrossTenant-originalarrivaltime: 25 Mar 2019 21:11:58.1280
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: a652971c-7d2e-4d9b-a6a4-d149256f461b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0501MB2749
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Alex Williamson <alex.williamson@redhat.com>
> Sent: Monday, March 25, 2019 2:21 PM
> To: Kirti Wankhede <kwankhede@nvidia.com>
> Cc: Parav Pandit <parav@mellanox.com>; kvm@vger.kernel.org; linux-
> kernel@vger.kernel.org
> Subject: Re: [PATCH 1/8] vfio/mdev: Fix to not do put_device on
> device_register failure
>=20
> On Mon, 25 Mar 2019 23:47:30 +0530
> Kirti Wankhede <kwankhede@nvidia.com> wrote:
>=20
> > On 3/23/2019 4:50 AM, Parav Pandit wrote:
> > > device_register() performs put_device() if device_add() fails.
> > > This balances with device_initialize().
> > >
> > > mdev core performing put_device() when device_register() fails, is
> > > an error that puts already released device again.
> > > Therefore, don't put the device on error.
> > >
> >
> > device_add() on all errors doesn't call put_device(dev). It releases
> > reference to its parent, put_device(parent), but not the device
> > itself, put_device(dev).
>=20
> Sort of, device_initialize() initializes the reference count to 1,
> device_add() increments the reference count to 2 via the get_device() and
> then drops it back to 1 on all exit paths.  The oddity is the failure pat=
h of
> get_device() itself, but that can only happen if passed a NULL device, wh=
ere
> put_device() is a no-op and not relevant here.  So in all cases
> device_register() returns with a reference count of 1 and we need to call
> put_device() to free the allocated object.  The below change would leak t=
he
> mdev on error.  Thanks,
>=20
Yes.
I missed the NOTE at the starting of device_add() comment block.
I will drop this patch in series.

> Alex
>=20
> > > Fixes: 7b96953bc640 ("vfio: Mediated device Core driver")
> > > Signed-off-by: Parav Pandit <parav@mellanox.com>
> > > ---
> > >  drivers/vfio/mdev/mdev_core.c | 4 +---
> > >  1 file changed, 1 insertion(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/vfio/mdev/mdev_core.c
> > > b/drivers/vfio/mdev/mdev_core.c index 0212f0e..3e5880a 100644
> > > --- a/drivers/vfio/mdev/mdev_core.c
> > > +++ b/drivers/vfio/mdev/mdev_core.c
> > > @@ -318,10 +318,8 @@ int mdev_device_create(struct kobject *kobj,
> struct device *dev, uuid_le uuid)
> > >  	dev_set_name(&mdev->dev, "%pUl", uuid.b);
> > >
> > >  	ret =3D device_register(&mdev->dev);
> > > -	if (ret) {
> > > -		put_device(&mdev->dev);
> > > +	if (ret)
> > >  		goto mdev_fail;
> > > -	}
> > >
> > >  	ret =3D mdev_device_create_ops(kobj, mdev);
> > >  	if (ret)
> > >