Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp3651355img; Mon, 25 Mar 2019 14:57:05 -0700 (PDT) X-Google-Smtp-Source: APXvYqzD4Qo4pE9YssRktj0W6pRieIuUaXwjv6CFRqf0xNiLcnvfai9vVSHAl9KbPRQo45NlFbc5 X-Received: by 2002:a63:e050:: with SMTP id n16mr25224903pgj.210.1553551024921; Mon, 25 Mar 2019 14:57:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553551024; cv=none; d=google.com; s=arc-20160816; b=jQ3spNe6kdlmwyENlZcvR8cZI/d15SdghJSiZxpb45u21mgIk55VRnypBUeiIjuaIy ZfCrJ+pxDYcyzrxav2yOKzO2LH5yT05cmF/vOYj8EBQDG9bMYNck4INZ34fYcTaJ5IxB sh+Q5Z3BhSkUzQm5YxIY1S9Lx1xBfsoNco08ZETg9qxDgJaef4Cf4PyBc+Pf6GfoZnhi NeYuMbo4sd6/BZGzuDQed8CFnIqGQVrjnQv6EBH6iWgi+UdcX2eikiBr6OO1B5xP2duy ArlmfF/bLgOzpVnBS0VId92VZBdEHccK4mu4kXRoEYA4jkgmpM5fAWD06J4Z+taBy6k7 WNww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date; bh=3rLf/rnj5QZHpHhUG2OK4BxkLllxiwT01QEZAy489Aw=; b=rwCrZDO9e1RsN7PuLH663BPscICPTox/aUIilUB4lDdfD4eQF+Y8R3pUc65DVs2NCR Ebjb/cqOGfRBFFfuo02wVqeOILK6iFku5K0JdM5sHjEe0tfjpO2ZA30MRKzC72PLYJ7F +7itSGu4Hn/BSc44tjFRlWINjpznVFKwFBG1u7RTlfcI2zCnk/1aamPBTrj53MgqwiRt Zlak2sYoTv+gHI5oPU4FK9Jj8usMnIvE1JAMdhArzEFy4E8i0a7We6S0BLAb1sCzSlVc 9KFDakpVdzKAnm/Nz2GQIFStwWcToEmZIxneospsJF+FeWrCDu+uqvG6AHOPVK9Wd/2P 2kIA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id w19si14463196ply.264.2019.03.25.14.56.49; Mon, 25 Mar 2019 14:57:04 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730361AbfCYVyh (ORCPT + 99 others); Mon, 25 Mar 2019 17:54:37 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:37234 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728563AbfCYVyh (ORCPT ); Mon, 25 Mar 2019 17:54:37 -0400 Received: from akpm3.svl.corp.google.com (unknown [104.133.8.65]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id 78091FB3; Mon, 25 Mar 2019 21:54:29 +0000 (UTC) Date: Mon, 25 Mar 2019 14:54:28 -0700 From: Andrew Morton To: Yury Norov Cc: Andy Shevchenko , Rasmus Villemoes , Arnd Bergmann , Kees Cook , Matthew Wilcox , Tetsuo Handa , Yury Norov , linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/6] bitmap_parselist: move non-parser logic to helpers Message-Id: <20190325145428.b826c281daa7f5cd1f110efe@linux-foundation.org> In-Reply-To: <20190325210748.6571-3-ynorov@marvell.com> References: <20190325210748.6571-1-ynorov@marvell.com> <20190325210748.6571-3-ynorov@marvell.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Mar 2019 00:07:44 +0300 Yury Norov wrote: > --- a/lib/bitmap.c > +++ b/lib/bitmap.c > @@ -477,6 +477,42 @@ int bitmap_print_to_pagebuf(bool list, char *buf, const unsigned long *maskp, > } > EXPORT_SYMBOL(bitmap_print_to_pagebuf); > > +/* > + * Region 9-38:4/10 describes the following bitmap structure: > + * 0 9 12 18 38 > + * .........****......****......****...... > + * ^ ^ ^ ^ > + * start off grlen end > + */ > +struct region { > + unsigned int start; > + unsigned int off; > + unsigned int grlen; > + unsigned int end; > +}; grlen means... group_len, I think? Perhaps it should be called group_len ;)