Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp3721532img; Mon, 25 Mar 2019 16:45:51 -0700 (PDT) X-Google-Smtp-Source: APXvYqy9u1i3zmsY00LgiGobxnfUXf3QybuP/xHjiDv8tc4//sYmqrHqBXL1mEgwrdDJs7EjOELv X-Received: by 2002:a62:565c:: with SMTP id k89mr26720346pfb.175.1553557551595; Mon, 25 Mar 2019 16:45:51 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553557551; cv=none; d=google.com; s=arc-20160816; b=XUU9AWh94xVcumzp82ILEEY7bpVp/QKTp14kGOGNf/LoqoaVNQg+WPDkBlupOjzUXi hV/3t/gfBe+T1+GgOW8NPk6dgDTvOAVGJEKgSQqd6Z19TezdDDS2u9GeO3dGvNqeVTic bq6v66w6jEBQne5xEjp60RexrEaUu0hkxdRX21JanYL0y/irJ1dNLZuwA/IKwyxRx/z0 w1PCSp15Tscw5HaFC1Dr06lN8IcSrg5CKoGqrro0cWtZgBkUoLWwefYxBsoOzSBa+qV+ NuGQ8opNupAUHL92BoDY0sN29BVCSVDUaRzIls2ssYp37rACL8WxI1GxPcKDylamEeIs Rv9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=etDxjsM9Oq3NHJQ+SQ3jlnMOWQWp78+pUjuw+dnW+Ds=; b=vnm54xCI4+RdXaStiCOQlwvCWmzU3oj19b2vDUVGqOddmL5b2sqHue3KY1IHhOn1je K/DaPHQWZyq1QDLokK3eKMFwxLmMaw/zPLbTenopga8pwcCN08RxTvSr09RW9YHgMb8v rADpfZ7+GrXuxunV80itooZn19gLKv2f4muh5LXY0HBx5Cqd7F5NAICTAqNwS13WfdIq 9YtIwCWCImdJyqg67Xp0Fhs2r+EVrt+CDR8vFpJF4bcZN4X31RRqNBaRj3VJKIbu5mZJ LHH7wVVyYdxBIFZI6yfCN6vY9xYVBYMttpDQHs2KaJ71UFfoimnIFVFFA3jiU9iAj4J/ Rwyw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Z9UfVDgP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b31si16044581plb.351.2019.03.25.16.45.36; Mon, 25 Mar 2019 16:45:51 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=Z9UfVDgP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727462AbfCYXoo (ORCPT + 99 others); Mon, 25 Mar 2019 19:44:44 -0400 Received: from mail-pg1-f196.google.com ([209.85.215.196]:34943 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726186AbfCYXon (ORCPT ); Mon, 25 Mar 2019 19:44:43 -0400 Received: by mail-pg1-f196.google.com with SMTP id g8so7355266pgf.2; Mon, 25 Mar 2019 16:44:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=etDxjsM9Oq3NHJQ+SQ3jlnMOWQWp78+pUjuw+dnW+Ds=; b=Z9UfVDgPKmnVQMFOE1ahz/vuUM9OipGgovWywGGS54Fui1y/9MZp4KoFSl5eEEcMGC yw777vb4DDkBSPbVXMm1EkSxj+ikmqJlaGbFTgTvps5/AW095qIs3QCm9mSwFNMaDvfm LZkUETeqaerHg/iGhESrZNn9ckQm3NlNIH2G6Udfv2VwiFTjYBesQm/Ysp1B0DSbjE5U G3zyc0rHqUfW6iknywwl8oYgCYKpTd9Bb3Y4guDms8ovwFyQatq74+tpR73l8brND9qG 8DE0N60fsh3Qg3otrpUhZlUA9H3C+XpwTjHR649FBxe9lukFhSWTV7jv/4b9bJbp7+Fp N1ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=etDxjsM9Oq3NHJQ+SQ3jlnMOWQWp78+pUjuw+dnW+Ds=; b=n5bPLEhg8BI//qGGsmJ6QE3rMUa24dzmvI95RG+mXGkxqY5NwL4GqHMhp9lOn85BnD 2BtsFIDHTk2es5uYxgpUVPpw/NByq70bKsvk/Gmp4TfzH24joO8TwE0aHqxrVIqU0Vc8 f/XCY0RFCcXQScX9VhaODgRsw5kD5eFU8Uz/2ezorQyvCxaSFi9Y5m+bFs9X0CDgRbYB MBSvUp0P/OwusYEd3fXOPqLT8M72rt1OteAPi1Cl+ZOr0V52DX/J6NQul5j4eUMINjHO GOxVKpGtKPn658UtdN/WELNNjR0QceSNuveHthLop2DQ6DNlx98idqP9djfZ6V1f6j8M wMoA== X-Gm-Message-State: APjAAAW+Gi5zfc0zLknjL6bw26j8SwwC5jYUDPmu4eKio2oyJGR/KHm/ zGqWIBhtQPMCmJO1mQ8B7sg= X-Received: by 2002:a62:2a97:: with SMTP id q145mr27320245pfq.22.1553557483270; Mon, 25 Mar 2019 16:44:43 -0700 (PDT) Received: from ast-mbp ([2620:10d:c090:200::3:b0d9]) by smtp.gmail.com with ESMTPSA id a7sm20671208pfc.45.2019.03.25.16.44.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 25 Mar 2019 16:44:42 -0700 (PDT) Date: Mon, 25 Mar 2019 16:44:40 -0700 From: Alexei Starovoitov To: Al Viro Cc: Linus Torvalds , syzbot , Alexei Starovoitov , Daniel Borkmann , linux-fsdevel , Linux List Kernel Mailing , syzkaller-bugs Subject: Re: KASAN: use-after-free Read in path_lookupat Message-ID: <20190325234439.jimxj6q4bs5ndrwf@ast-mbp> References: <0000000000006946d2057bbd0eef@google.com> <20190325045744.GK2217@ZenIV.linux.org.uk> <20190325211405.GP2217@ZenIV.linux.org.uk> <20190325233731.GS2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190325233731.GS2217@ZenIV.linux.org.uk> User-Agent: NeoMutt/20180223 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 25, 2019 at 11:37:32PM +0000, Al Viro wrote: > > For debugfs it's clearly "use default ->evict_inode(), have explicit > ->destroy_inode() using free_inode_nonrcu()" - there we have nothing > else done in ->evict_inode() and kfree is obviously safe in softirq. > I'll post that (or push to vfs.git#fixes), along with minimal fixes > for other 3. If bpf_any_put() is softirq-safe, we'll have the full > set for -stable and the rest could be done on top of that. Yes. bpf_any_put() is safe to be called from softirq.