Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp3797586img; Mon, 25 Mar 2019 18:46:55 -0700 (PDT) X-Google-Smtp-Source: APXvYqx9nHV5Y1+3TNoseZSu/ijuMwd2sDsOg/ncJiNXQN+OvptXXIvZkiooJUBudvAzRr6xZXtW X-Received: by 2002:a63:5a1d:: with SMTP id o29mr21796018pgb.320.1553564815554; Mon, 25 Mar 2019 18:46:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553564815; cv=none; d=google.com; s=arc-20160816; b=Ucu0ouRyoyVlUBwLykdSnGY7WNAA3xxDgGoAjlwpzYnHEWzYoBeDyZMWV3Pf+TN1lU /9M6NZB86h+T6rt5YskNqJ1mFHuIxT33yeLGFCGcXa1OSGtjMnvr0dBuzl7mN65Iatc1 sDbUy1m5isiGr1K+6brIhytBVOWqzXJ98CrhMyeRMbRA44e/P0SHeTzsdOQCSn7L+/B7 GniHbHGZzIoqKS1Eqc0/RmkfNohiJY/hOOt9cmUp9UByqOGVOiMkWJIPnvtXUFOOUy7g GBb1QgVJOw9BARTTsq6xcqdFXRVKJx3EGIhKtW7dh0G8Auc2mf1QDnwtM8ZMcEfRkBYT mjnQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Tyw+9/0GbPQKyuHE71tglyVJsjhNflxPLnxRJJP1mXA=; b=0ke8wvx66xBIpBj2xJkn1lKx7wVL5Z1RFqNilaZTtvqdb2VN2HMuZAnfldRTPPKHJK OUpmXZqLMcgwJTE1g5ga32SNy+cbDoNPsMMDsFwiYgj3lKX+8BOXycBbHd8sk9783/J9 +VDo9az6q8WzEHKLugSPPXvgLT3pMP3892RQQszT4/IVVeBgdG586xX97r7nuJDGguo7 EgfHxp4ndBFpZESUmDaXWsVPxvlmr5Hx95BZ7An32O+fcP/IaBRh+fVWSZwo8JqQ+ngT VaaWr2yfR7cFCduZvaR3YU6dspdBFk5OI1BjdHKNHEzx5TdL8a1Ejznl1joDcCgSnUHt YPOg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id n14si14315088pgl.277.2019.03.25.18.46.40; Mon, 25 Mar 2019 18:46:55 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730622AbfCZBp5 (ORCPT + 99 others); Mon, 25 Mar 2019 21:45:57 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:58730 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727412AbfCZBp5 (ORCPT ); Mon, 25 Mar 2019 21:45:57 -0400 Received: from viro by ZenIV.linux.org.uk with local (Exim 4.92 #3 (Red Hat Linux)) id 1h8bA1-0004h2-21; Tue, 26 Mar 2019 01:45:53 +0000 Date: Tue, 26 Mar 2019 01:45:53 +0000 From: Al Viro To: Linus Torvalds Cc: syzbot , Alexei Starovoitov , Daniel Borkmann , linux-fsdevel , Linux List Kernel Mailing , syzkaller-bugs Subject: Re: KASAN: use-after-free Read in path_lookupat Message-ID: <20190326014552.GY2217@ZenIV.linux.org.uk> References: <0000000000006946d2057bbd0eef@google.com> <20190325045744.GK2217@ZenIV.linux.org.uk> <20190325211405.GP2217@ZenIV.linux.org.uk> <20190325233731.GS2217@ZenIV.linux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20190325233731.GS2217@ZenIV.linux.org.uk> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Mar 25, 2019 at 11:37:32PM +0000, Al Viro wrote: > For debugfs it's clearly "use default ->evict_inode(), have explicit > ->destroy_inode() using free_inode_nonrcu()" - there we have nothing > else done in ->evict_inode() and kfree is obviously safe in softirq. > I'll post that (or push to vfs.git#fixes), along with minimal fixes > for other 3. If bpf_any_put() is softirq-safe, we'll have the full > set for -stable and the rest could be done on top of that. > > Won't solve the documetation problem, unfortunately ;-/ Posted; all of those (as well as Daniel's bpf patch) are Cc:stable fodder. Documentation is still, er, deficient...