Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553564407-1162-1-git-send-email-laoar.shao@gmail.com> <20190325221745.1009cbdf@oasis.local.home>
In-Reply-To: <20190325221745.1009cbdf@oasis.local.home>
From:   Yafang Shao <laoar.shao@gmail.com>
Date:   Tue, 26 Mar 2019 10:24:35 +0800
Message-ID: <CALOAHbAUaRVCL_z2Kq45r-iwRqo5OwGMoEHrDJPj1fJsXbH6iA@mail.gmail.com>
Subject: Re: [PATCH 0/3] tracing: introduce TRACE_EVENT_NONE and use it
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     mingo@redhat.com, Peter Zijlstra <peterz@infradead.org>,
        Paul McKenney <paulmck@linux.vnet.ibm.com>,
        josh@joshtriplett.org,
        Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
        jiangshanlai@gmail.com, joel@joelfernandes.org,
        shaoyafang@didiglobal.com, LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 26, 2019 at 10:17 AM Steven Rostedt <rostedt@goodmis.org> wrote:
>
> On Tue, 26 Mar 2019 09:40:04 +0800
> Yafang Shao <laoar.shao@gmail.com> wrote:
>
> > In this patchset, I introduce a new macro TRACE_EVENT_NONE(), which will
> > define a tracepoint as a do-nothing inline function.
> >       #define TRACE_EVENT_NONE(name, proto)                   \
> >               static inline void trace_##name(proto)          \
> >               { }                                             \
> >               static inline bool trace_##name##_enabled(void) \
> >               {                                               \
> >                       return false;                           \
> >               }
> >
>
> BTW, I prefer a name of TRACE_EVENT_DISABLED()
>
> Which shows that it is disabled, or TRACE_EVENT_UNDEF(), or
> TRACE_EVENT_NOP(). Something that states it is turned off. When I first
> saw NONE() I thought it was another attempt to introduce zero parameter
> trace events.
>

I prefer TRACE_EVENT_NOP.
I will change it.

Thanks
Yafang

>
> > Let's take some example for why this macro is needed.
> >
> > - sched
> > The tracepoints trace_sched_stat_{iowait, blocked, wait, sleep} should
> > be not exposed to user if CONFIG_SCHEDSTATS is not set.
> > We can place #ifdef in the kernel/sched/fair.c to fix it, but we
> > don't want to sprinkle #ifdef.
>
> But you still sprinkle #ifdef in the header, but the part I don't like
> is the need to duplicate the prototypes and the like.
>
>
> > So with TRACE_EVENT_NONE(), we can fix it in
> > include/trace/events/sched.h.
> >
> > - rcu
> > When CONFIG_RCU_TRACE is not set, some rcu tracepoints are define as
> > do-nothing macro without validating arguments, that is not proper.
> > We should validate the arguments.
> >
> > Yafang Shao (3):
> >   tracing: introduce TRACE_EVENT_NONE()
> >   sched/fair: do not expose some tracepoints to user if
> >     CONFIG_SCHEDSTATS is not set
> >   rcu: validate arguments for rcu tracepoints
> >
>
> See my reply in the next patch.
>
> -- Steve