Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp3819470img; Mon, 25 Mar 2019 19:27:29 -0700 (PDT) X-Google-Smtp-Source: APXvYqxaJxJ+7gzchnGxCOlREwv4eOKvfr7Z2QEyEuiz3y23UieBFo7zJ5J0QxpIr2EBjFydhZlZ X-Received: by 2002:a17:902:aa85:: with SMTP id d5mr4992417plr.251.1553567249409; Mon, 25 Mar 2019 19:27:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553567249; cv=none; d=google.com; s=arc-20160816; b=c7Z2aJT2qlIjXO+Wr2UJrpnLTcu3BXCugpzrMzxQnZ1gUzn6wCh6mqrplvZ1HtvlWx v60YZUKYLZnyT/bAIY7CFNjkdtZJeLUEqCIWYjkwxKvuJ0mrbEzYlrfFzcsJoI/elfT+ M5mvyZjxXncxqCmPn80Tm3htdm12b8JCPyummV2n6tKqwFJm72jvl/n+TB3Lc4243Sv6 wb9diOMrPL8ZRIROUor1u8V0aF7vxXzD+KRgaR+kt9zLZaMr5WMfzslTE3Orw3ESkY/v 9M7OAT/WhLkGJ8p21C3Cc6wVYssR5ry8l0vrWb/n0/U8xwoX66urQ6lkuY1EMGl8mUri fmkQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:message-id :in-reply-to:date:references:organization:from:subject:cc:to :dkim-signature; bh=YlN08lgWqUjAGIaUpT9fV5glukI3seX0g5Ww3GQPoic=; b=lYdNrz1WkwgdNbLeCvnG/TryVp1DQBcNa5oTfsFEJTSbmq6hFcgTE4IYkeWd62yvTQ Kiu/thAAOsVVEpkVV68ka8Nx30z8+tmVskXlmx/yUbAy56p8lcdPkG2V0xRTF3YKVDs1 seuOs6B/eDZ39MUndZ9/0b4czZIVJ4+ymDcpGVXps/KcNjIFWhTgZt3gygdd+CFCqAts tWdMvqmeiUfCQEJaChcO8t8uuteS+dZ1YJsbyCGEvH8Ar77hIwq+VphIOGaUJCFmhuS5 ijZGWPYZM41HjFevOFPWahufmwZYMa3kGEdJ6K3GvieSkvhD3S8j7NaGX/sS6zT3Htn2 bKww== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=YyVPVkry; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q189si15020528pga.544.2019.03.25.19.27.13; Mon, 25 Mar 2019 19:27:29 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@oracle.com header.s=corp-2018-07-02 header.b=YyVPVkry; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=oracle.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731088AbfCZCZi (ORCPT + 99 others); Mon, 25 Mar 2019 22:25:38 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:54688 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730273AbfCZCZh (ORCPT ); Mon, 25 Mar 2019 22:25:37 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.27/8.16.0.27) with SMTP id x2Q2P5SX077370; Tue, 26 Mar 2019 02:25:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=to : cc : subject : from : references : date : in-reply-to : message-id : mime-version : content-type; s=corp-2018-07-02; bh=YlN08lgWqUjAGIaUpT9fV5glukI3seX0g5Ww3GQPoic=; b=YyVPVkryj2pD/q8vyuw3DdS847Vjky17X8RuUS0gQi9LnN6zlMnnnY4IPgSwZ+1SWQza i9NMvFqQAIEjWOENlSNcpaSYYC0f8irdr04ZHNq7A0/+wj8Nrcc3DNZeFNDTXV/b/pAl 1l+W40futhu8fRiOiATS+7ztV5DKppBcdvecRdT6hyR4rU+mbiLqOhvRDVCCMUeFdXZF llcaU+KTOZQ3Z3lVh4NeK3YhzhHi0Qei2oxUKZKof43ZUs1lNk8adj/tO0A205y11vax TaZmGTLEVRDm64KnrPaNAISbV0kmjx0/nesv3ADC8fdOn8iaaoGUHhIILM6J0TbBXoXU sA== Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2re6dj7ngt-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Mar 2019 02:25:32 +0000 Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id x2Q2PVT7001141 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 26 Mar 2019 02:25:31 GMT Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id x2Q2PT10028429; Tue, 26 Mar 2019 02:25:30 GMT Received: from ca-mkp.ca.oracle.com (/10.159.214.123) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 25 Mar 2019 19:25:29 -0700 To: Kangjie Lu Cc: pakki001@umn.edu, QLogic-Storage-Upstream@qlogic.com, "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: qla4xxx: fix a potential NULL pointer dereference From: "Martin K. Petersen" Organization: Oracle Corporation References: <20190314063100.12805-1-kjlu@umn.edu> Date: Mon, 25 Mar 2019 22:25:26 -0400 In-Reply-To: <20190314063100.12805-1-kjlu@umn.edu> (Kangjie Lu's message of "Thu, 14 Mar 2019 01:30:59 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9206 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=583 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1903260016 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Kangjie, > In case iscsi_lookup_endpoint fails, the fix returns -EINVAL to avoid > NULL pointer dereference. Applied to 5.1/scsi-fixes, thanks. -- Martin K. Petersen Oracle Linux Engineering