Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <1553568933.21970.6.camel@mhfsdcap03>
Subject: Re: [PATCH RESEND v3 3/4] arm64: dts: mt8183: add pintcrl device
 node
From:   Zhiyong Tao <zhiyong.tao@mediatek.com>
To:     Nicolas Boichat <drinkcat@chromium.org>
CC:     Rob Herring <robh+dt@kernel.org>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Rutland <mark.rutland@arm.com>,
        "Matthias Brugger" <matthias.bgg@gmail.com>,
        Sean Wang <sean.wang@kernel.org>,
        srv_heupstream <srv_heupstream@mediatek.com>,
        <hui.liu@mediatek.com>, "Eddie Huang" <eddie.huang@mediatek.com>,
        <chuanjia.liu@mediatek.com>, <biao.huang@mediatek.com>,
        <hongzhou.yang@mediatek.com>, Erin Lo <erin.lo@mediatek.com>,
        Sean Wang <sean.wang@mediatek.com>,
        <devicetree@vger.kernel.org>, lkml <linux-kernel@vger.kernel.org>,
        "linux-arm Mailing List" <linux-arm-kernel@lists.infradead.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>, <linux-gpio@vger.kernel.org>
Date:   Tue, 26 Mar 2019 10:55:33 +0800
In-Reply-To: <CANMq1KCSN11fH0JS72iheDwKjo06ShKiFu+Yn51xVObcvV37GA@mail.gmail.com>
References: <20190325124137.6117-1-zhiyong.tao@mediatek.com>
         <20190325124137.6117-4-zhiyong.tao@mediatek.com>
         <CANMq1KCSN11fH0JS72iheDwKjo06ShKiFu+Yn51xVObcvV37GA@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2019-03-25 at 11:17 -0700, Nicolas Boichat wrote:
> On Mon, Mar 25, 2019 at 5:41 AM Zhiyong Tao <zhiyong.tao@mediatek.com> wrote:
> >
> > The commit adds pintcrl device node for mt8183
> 
> Minor nit: This should say pinctrl (in the commit title as well).
==> Thanks for your suggestion, we will change it in next version.
> 
> >
> > Signed-off-by: Zhiyong Tao <zhiyong.tao@mediatek.com>
> > ---
> >  arch/arm64/boot/dts/mediatek/mt8183.dtsi | 26 +++++++++++++++++++++++++-
> >  1 file changed, 25 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183.dtsi b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > index 75c4881bbe5e..cf92504e2a9b 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183.dtsi
> > @@ -9,7 +9,7 @@
> >  #include <dt-bindings/interrupt-controller/arm-gic.h>
> >  #include <dt-bindings/interrupt-controller/irq.h>
> >  #include <dt-bindings/power/mt8183-power.h>
> > -
> > +#include "mt8183-pinfunc.h"
> >  / {
> >         compatible = "mediatek,mt8183";
> >         interrupt-parent = <&sysirq>;
> > @@ -197,6 +197,30 @@
> >                         #clock-cells = <1>;
> >                 };
> >
> > +               pio: pinctrl@10005000 {
> > +                       compatible = "mediatek,mt8183-pinctrl";
> > +                       reg = <0 0x10005000 0 0x1000>,
> > +                             <0 0x11f20000 0 0x1000>,
> > +                             <0 0x11e80000 0 0x1000>,
> > +                             <0 0x11e70000 0 0x1000>,
> > +                             <0 0x11e90000 0 0x1000>,
> > +                             <0 0x11d30000 0 0x1000>,
> > +                             <0 0x11d20000 0 0x1000>,
> > +                             <0 0x11c50000 0 0x1000>,
> > +                             <0 0x11f30000 0 0x1000>,
> > +                             <0 0x1000b000 0 0x1000>;
> > +                       reg-names = "iocfg0", "iocfg1", "iocfg2",
> > +                                   "iocfg3", "iocfg4", "iocfg5",
> > +                                   "iocfg6", "iocfg7", "iocfg8",
> > +                                   "eint";
> > +                       gpio-controller;
> > +                       #gpio-cells = <2>;
> > +                       gpio-ranges = <&pio 0 0 192>;
> > +                       interrupt-controller;
> > +                       interrupts = <GIC_SPI 177 IRQ_TYPE_LEVEL_HIGH>;
> > +                       #interrupt-cells = <2>;
> > +               };
> > +
> >                 scpsys: syscon@10006000 {
> >                         compatible = "mediatek,mt8183-scpsys", "syscon";
> >                         #power-domain-cells = <1>;
> > --
> > 2.12.5
> >