Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <362a9b5f-8908-17f5-3594-6c3c68789dea@molgen.mpg.de>
 <CAEJqkggKGTn0ojWzuYGfoYehDnOf=je5L-7-M1kWogutPGMg3g@mail.gmail.com>
 <874l8ic0l4.fsf@codeaurora.org> <CAEJqkgjYRu1Az6ec1ksQfLZ71fa062Us7XkOzw8BZ2bEoUe8BQ@mail.gmail.com>
 <87wol97hvp.fsf@kamboji.qca.qualcomm.com> <CA+ASDXOcbSGJs3Xk_SjjsAA87fcwrx_JB_mB9cyV=9u6V+FZ_A@mail.gmail.com>
In-Reply-To: <CA+ASDXOcbSGJs3Xk_SjjsAA87fcwrx_JB_mB9cyV=9u6V+FZ_A@mail.gmail.com>
From:   Claire Chang <tientzu@google.com>
Date:   Tue, 26 Mar 2019 11:46:26 +0800
Message-ID: <CALiNf2-Wdo4YnKLprUUyPF9QJBL10Mz3wvVG6fWtd_Xi-Yn=6w@mail.gmail.com>
Subject: Re: Warning at drivers/net/wireless/ath/ath10k/mac.c:5625 ath10k_bss_info_changed
To:     Brian Norris <briannorris@chromium.org>
Cc:     Kalle Valo <kvalo@codeaurora.org>,
        Gabriel C <nix.or.die@gmail.com>,
        Paul Menzel <pmenzel@molgen.mpg.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        ath10k@lists.infradead.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi

On Tue, Mar 26, 2019 at 12:49 AM Brian Norris <briannorris@chromium.org> wr=
ote:
>
> Hi Kalle,
>
> On Fri, Mar 8, 2019 at 2:58 AM Kalle Valo <kvalo@codeaurora.org> wrote:
> > Gabriel C <nix.or.die@gmail.com> writes:
> > > Am Mo., 4. M=C3=A4rz 2019 um 12:59 Uhr schrieb Kalle Valo <kvalo@code=
aurora.org>:
> > >> Gabriel C <nix.or.die@gmail.com> writes:
> > >> > I reported that twice and no one seems to care about.
> > >> >
> > >> > http://lists.infradead.org/pipermail/ath10k/2018-November/012398.h=
tml
> > >> > http://lists.infradead.org/pipermail/ath10k/2018-December/012658.h=
tml
> > >>
> > >> Does this patch help:
> > >>
> > >> ath10k: Drop WARN_ON()s that always trigger during system resume
> > >>
> > >> https://patchwork.kernel.org/patch/10837139/
> > >>
> > >
> > > Without to test this patch I can confirm it will help , I dropped the
> > > WARN_ON()'s in 4.19 already.
> > > If I remember right 4.19 has one WARN_ON() triggers while 4.20 got tw=
o.
> >
> > Ok, thanks. I'll try to get this patch to 5.1.
>
> Ping? Is there any solution queued anywhere? It's kinda sad how long
> this has sat here.
>
> Brian

Do we need to set mcast rate and basic rates during/after system resume?
Dropping the WARN_ON() will solve the warning issue, but won't make
those rates set properly.