Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
To:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kvm@vger.kernel.org" <kvm@vger.kernel.org>
CC:     "joro@8bytes.org" <joro@8bytes.org>,
        "pbonzini@redhat.com" <pbonzini@redhat.com>,
        "rkrcmar@redhat.com" <rkrcmar@redhat.com>,
        "vkuznets@redhat.com" <vkuznets@redhat.com>,
        "Suthikulpanit, Suravee" <Suravee.Suthikulpanit@amd.com>
Subject: [PATCH v2] svm/avic: Fix invalidate logical APIC id entry
Thread-Topic: [PATCH v2] svm/avic: Fix invalidate logical APIC id entry
Thread-Index: AQHU44gM6vK3inub30eEmN0VlYxwVQ==
Date:   Tue, 26 Mar 2019 03:57:37 +0000
Message-ID: <20190326035711.77916-1-suravee.suthikulpanit@amd.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-messagesentrepresentingtype: 1
x-mailer: git-send-email 2.17.1
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: a548e3b3-fa27-43df-b39f-08d6b19f2f26
x-ms-office365-filtering-ht: Tenant
x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(5600127)(711020)(4605104)(4618075)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(2017052603328)(7153060)(7193020);SRVR:DM6PR12MB3209;
x-ms-traffictypediagnostic: DM6PR12MB3209:
x-microsoft-antispam-prvs: <DM6PR12MB3209BC1A5BF4580526C9D67EF35F0@DM6PR12MB3209.namprd12.prod.outlook.com>
x-forefront-prvs: 09888BC01D
x-forefront-antispam-report: SFV:NSPM;SFS:(10009020)(39860400002)(376002)(366004)(396003)(346002)(136003)(199004)(189003)(7736002)(6512007)(1076003)(106356001)(99286004)(3846002)(54906003)(110136005)(68736007)(71190400001)(4326008)(2616005)(71200400001)(86362001)(2501003)(66066001)(476003)(316002)(50226002)(81156014)(6116002)(81166006)(102836004)(256004)(8676002)(14444005)(5660300002)(305945005)(105586002)(26005)(25786009)(6486002)(6436002)(478600001)(8936002)(52116002)(6506007)(386003)(36756003)(53936002)(72206003)(486006)(2906002)(97736004)(186003)(14454004);DIR:OUT;SFP:1101;SCL:1;SRVR:DM6PR12MB3209;H:DM6PR12MB2844.namprd12.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1;
received-spf: None (protection.outlook.com: amd.com does not designate
 permitted sender hosts)
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam-message-info: el0ApbgR9Hmir8YBAVZrTQgP0NBJ7Pk2cwBgoouacbHwFHpod/PQhWKiaRLXvlK/6SrkzBD7a70oBvamTdHnz2/p0g7UvAiUfW8k2gPoVtWq9AprIImL0uyt3PfzvCneeTEbKg7JdjZO4se9OrIq1eBhH5H9vDEXZBp2JyczyPBXSygzk8CRca7G5bmIB98SQn8RaRauN1CNNCDF9H4mI8pmf0lCX6JXJs7LmChayRBcdoT6I4mv5f02ZhuMD43HTD5uqb29RrFDP427lrYe/io1CcFb6TUHCpUN3F8NdPP+d+udWhLm8nOUdsc8r2VCaEEP2/NgANNL/vgbZPyqJBpxZtxV1xSeDN12oG+jKR4o5lLuhXPlo/R/jgT9BsxILALsmztkpKebXxMs9TqmJsUOxrUEq8tiJhvdX9g/KIg=
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a548e3b3-fa27-43df-b39f-08d6b19f2f26
X-MS-Exchange-CrossTenant-originalarrivaltime: 26 Mar 2019 03:57:37.3049
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB3209
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Only clear the valid bit when invalidate logical APIC id entry.
The current logic clear the valid bit, but also set the rest of
the bits (including reserved bits) to 1.

Fixes: 98d90582be2e ('svm: Fix AVIC DFR and LDR handling')
Signed-off-by: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
---
 arch/x86/kvm/svm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/arch/x86/kvm/svm.c b/arch/x86/kvm/svm.c
index 7a4ce1a22ca0..8a123bd0f591 100644
--- a/arch/x86/kvm/svm.c
+++ b/arch/x86/kvm/svm.c
@@ -270,6 +270,7 @@ struct amd_svm_iommu_ir {
 };
=20
 #define AVIC_LOGICAL_ID_ENTRY_GUEST_PHYSICAL_ID_MASK	(0xFF)
+#define AVIC_LOGICAL_ID_ENTRY_VALID_BIT			31
 #define AVIC_LOGICAL_ID_ENTRY_VALID_MASK		(1 << 31)
=20
 #define AVIC_PHYSICAL_ID_ENTRY_HOST_PHYSICAL_ID_MASK	(0xFFULL)
@@ -4640,7 +4641,7 @@ static void avic_invalidate_logical_id_entry(struct k=
vm_vcpu *vcpu)
 	u32 *entry =3D avic_get_logical_id_entry(vcpu, svm->ldr_reg, flat);
=20
 	if (entry)
-		WRITE_ONCE(*entry, (u32) ~AVIC_LOGICAL_ID_ENTRY_VALID_MASK);
+		clear_bit(AVIC_LOGICAL_ID_ENTRY_VALID_BIT, (unsigned long *)entry);
 }
=20
 static int avic_handle_ldr_update(struct kvm_vcpu *vcpu)
--=20
2.17.1