Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp3964793img; Mon, 25 Mar 2019 23:40:46 -0700 (PDT) X-Google-Smtp-Source: APXvYqwoGCSvWXC2jOHleaBc/h7pSrYbiasv6jJx+4BAs7dvzv8jVRvSuZgmwtUiD2LFZtFM6yAB X-Received: by 2002:a62:5c87:: with SMTP id q129mr27201638pfb.180.1553582446742; Mon, 25 Mar 2019 23:40:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553582446; cv=none; d=google.com; s=arc-20160816; b=JYlGPr5NtUJeryCPfkc25opAmRRuDTIpTP5b9BrTdAl4n2nSu06BEZGo/3N9MSu+eB x0iAmDNIZkDlgiXGeiSXeZ/Zf5QHC54XpK0yCqCxpH9xfCptDZff72MyUAhVNhML4Dkw hZR4acU7L56Os+KpOgxgJK/qVIB2yRTwc+KfsadEFm8kM9SJWRxEyv40G3vvoXDisE/Y cz1chQk9dyD1io6XVEAT0xQsdrgw86SlVTpyq7XJDqgIYmRnfujnPWUq6fxDydacz5gW rAGaNjIDrH7C54wPXguFQBmDq2Wp/eu34L1QMbE/bCuTGNwAtsV8lmLGdDw1vcbgRk/a HjqA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=MFX+4VX+vvIflJ+hdoZWKOHeFSN5A74mr24WbromoKc=; b=VuWBv6Mv81f9QaepJpFfvQf8w+uwmMDlSN4cagGTYTF3ZAylH9Uu3D3H44/eRkyy2l DY4fmKuIwxu/Kb7bAMmMwP0nRElJBJ9oa47u+kdG3yGAHk1090WkrdeHFQmggbIf5ods Z0faklFMT9wFTN7DGHi6CNIj/W362K/eOT/gSumRWfECV2aOhvy5uJvO93kl8/Sx1Or1 wdy/Hnkw+xgJlNao0zRbKQEdfB4lgJjQOKij9LFAK+s3Sssl5KnKWbjUrUN51eRIQI6b VbXWo4JZFOn4UBM31mBP8CBIIDH9UX+Eg/I7hyjPZp1QrIVz1cp5cnMCERaSh0KpfY0N eBtw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tii8Hext; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id s14si15027726pgs.98.2019.03.25.23.40.31; Mon, 25 Mar 2019 23:40:46 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=tii8Hext; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732515AbfCZGiU (ORCPT + 99 others); Tue, 26 Mar 2019 02:38:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:52700 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730133AbfCZGiR (ORCPT ); Tue, 26 Mar 2019 02:38:17 -0400 Received: from localhost (unknown [104.132.152.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 718642086C; Tue, 26 Mar 2019 06:38:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553582297; bh=V7hmJkV+/F95Ru0uHHTSvJfuwHDhMzntCi75k/+SB3k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tii8HextkUN8WSNytSvdiMqXxDwri+lPV84q4/6rzqfOzYlVsrL5RubEjxI2ZzSDD vcBsYtUurDkzo+uo/s3BNyGezfGsufJCn88Xaf3M/e3VcDlpba4WdACmxmNq4vR2JS CusbY8Ge47JW0wyWEqYaM2FR9Sud7AX+31xMsRHs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, jean-luc malet , Jan Kara Subject: [PATCH 5.0 13/52] udf: Fix crash on IO error during truncate Date: Tue, 26 Mar 2019 15:30:00 +0900 Message-Id: <20190326042701.589643019@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190326042700.963224437@linuxfoundation.org> References: <20190326042700.963224437@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 5.0-stable review patch. If anyone has any objections, please let me know. ------------------ From: Jan Kara commit d3ca4651d05c0ff7259d087d8c949bcf3e14fb46 upstream. When truncate(2) hits IO error when reading indirect extent block the code just bugs with: kernel BUG at linux-4.15.0/fs/udf/truncate.c:249! ... Fix the problem by bailing out cleanly in case of IO error. CC: stable@vger.kernel.org Reported-by: jean-luc malet Signed-off-by: Jan Kara Signed-off-by: Greg Kroah-Hartman --- fs/udf/truncate.c | 3 +++ 1 file changed, 3 insertions(+) --- a/fs/udf/truncate.c +++ b/fs/udf/truncate.c @@ -260,6 +260,9 @@ void udf_truncate_extents(struct inode * epos.block = eloc; epos.bh = udf_tread(sb, udf_get_lb_pblock(sb, &eloc, 0)); + /* Error reading indirect block? */ + if (!epos.bh) + return; if (elen) indirect_ext_len = (elen + sb->s_blocksize - 1) >>