Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp3968881img; Mon, 25 Mar 2019 23:46:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqwt7a8QyYqw8veX3gR2SIT5i9vmZjNdYs6bTr+YhRo/XwY+AMGIj2ZS+mHQ4Qnl6VkJNQOm X-Received: by 2002:a63:170d:: with SMTP id x13mr24469506pgl.169.1553582813112; Mon, 25 Mar 2019 23:46:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553582813; cv=none; d=google.com; s=arc-20160816; b=EO5zuazVXRyVvnArBIoWjZ5/Zq+m09v6jG9t4ty7K6BnkKF4EPdow+Fq7FegeCZ+gv ebsVSr1CWlsqlmTUP4ImBWXvHvIyYJWr24o/wDA4RXRuLfugXlkPGLikkrRCBReiubOa oHKsnw5pGzs2cEBdeEXL1QedMHTbO185T66Uq+7+vo6gFS7vayRKZWTMeEtgArNKwHLg B2eRs3zhzWnLTc+cflYgbzXZ2igiDS4W3KIv3ULPGKoCA2BspfLGbSi7ppBqAGoshsg5 YTkFCxcRJx8YciNB/wMKV/uoHacAAPxMHGw7t0/gm1aqJ5X90ofcp3XR+0AgUc6OH7Gh O9vg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=D6xKIg39wTY0EdTA381mUsRF/P7lwROgiQWcTaFgmwM=; b=kNwDeMJ6UlchJA0n9m6Nb7RXDAxRZEZ+lnscNuqTFIzM7vli/quu52bWV6jmInFwcv fFkm1Sez7iykJXr351UkVLap5PBSmKEFzE1JbQ1nZlrDK4e/tvh7IxH2ZkljZ/Eh3IFR FeYXRaJp1pUfwcAa26J6JL+Z1K4tGw1Tt3Lv5y/Fk/4SdpUGkOoOhE/TCozfM3cv3daB g5P4Usp4HDlbg0bHWsdUjUgPdBZBX/Y9X+VINuNzIiuqg6h2M7ZIKC0Tcrta0IruYds7 sWjzG+Hut77xTMU9R7h2zyPtuOCcBa9IiuqrJPUxssqCAA8T5vIboZclbtRaE1QrV0af qbqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=t77PBvCr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f2si15367977pgv.10.2019.03.25.23.46.38; Mon, 25 Mar 2019 23:46:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=t77PBvCr; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731735AbfCZGdt (ORCPT + 99 others); Tue, 26 Mar 2019 02:33:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:43736 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731286AbfCZGdp (ORCPT ); Tue, 26 Mar 2019 02:33:45 -0400 Received: from localhost (unknown [104.132.152.111]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3BF5220863; Tue, 26 Mar 2019 06:33:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1553582024; bh=F1YfpALKtO4lHpVsu22mn6sbJ178mPk0mxzE3NzgAF4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=t77PBvCrdtNHXV2V9NeIPccMbMkiPtusTrGAWBXzfBUelzyJ9PZw3L2qozImECCOe GcSNw0RNSkNXFzucoiiKVbHbWUz1Hcsqow7Op42BtZLfj+7+0tC7v/N3uZNvK5226N cahGjSqNEOVzF10leZhmffbfn2Jk5z/CGqJdoGdE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Yasha Cherikovsky , Paul Burton , Ralf Baechle , James Hogan , linux-mips@linux-mips.org Subject: [PATCH 4.14 07/41] MIPS: Ensure ELF appended dtb is relocated Date: Tue, 26 Mar 2019 15:29:44 +0900 Message-Id: <20190326042650.250052485@linuxfoundation.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20190326042649.889479098@linuxfoundation.org> References: <20190326042649.889479098@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.14-stable review patch. If anyone has any objections, please let me know. ------------------ From: Yasha Cherikovsky commit 3f0a53bc6482fb09770982a8447981260ea258dc upstream. This fixes booting with the combination of CONFIG_RELOCATABLE=y and CONFIG_MIPS_ELF_APPENDED_DTB=y. Sections that appear after the relocation table are not relocated on system boot (except .bss, which has special handling). With CONFIG_MIPS_ELF_APPENDED_DTB, the dtb is part of the vmlinux ELF, so it must be relocated together with everything else. Fixes: 069fd766271d ("MIPS: Reserve space for relocation table") Signed-off-by: Yasha Cherikovsky Signed-off-by: Paul Burton Cc: Ralf Baechle Cc: Paul Burton Cc: James Hogan Cc: linux-mips@linux-mips.org Cc: linux-kernel@vger.kernel.org Cc: stable@vger.kernel.org # v4.7+ Signed-off-by: Greg Kroah-Hartman --- arch/mips/kernel/vmlinux.lds.S | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) --- a/arch/mips/kernel/vmlinux.lds.S +++ b/arch/mips/kernel/vmlinux.lds.S @@ -140,6 +140,13 @@ SECTIONS PERCPU_SECTION(1 << CONFIG_MIPS_L1_CACHE_SHIFT) #endif +#ifdef CONFIG_MIPS_ELF_APPENDED_DTB + .appended_dtb : AT(ADDR(.appended_dtb) - LOAD_OFFSET) { + *(.appended_dtb) + KEEP(*(.appended_dtb)) + } +#endif + #ifdef CONFIG_RELOCATABLE . = ALIGN(4); @@ -164,11 +171,6 @@ SECTIONS __appended_dtb = .; /* leave space for appended DTB */ . += 0x100000; -#elif defined(CONFIG_MIPS_ELF_APPENDED_DTB) - .appended_dtb : AT(ADDR(.appended_dtb) - LOAD_OFFSET) { - *(.appended_dtb) - KEEP(*(.appended_dtb)) - } #endif /* * Align to 64K in attempt to eliminate holes before the