Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 2E7F5607C3
Subject: Re: [PATCH] firmware: arm_scmi: Fix leak in scmi_mailbox_check
To:     Steven Price <steven.price@arm.com>,
        Sudeep Holla <sudeep.holla@arm.com>,
        linux-arm-kernel@lists.infradead.org
Cc:     linux-kernel@vger.kernel.org
References: <20190325173722.49414-1-steven.price@arm.com>
From:   Mukesh Ojha <mojha@codeaurora.org>
Message-ID: <dcf27d87-e72f-3892-f982-941c91f95102@codeaurora.org>
Date:   Tue, 26 Mar 2019 12:53:44 +0530
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101
 Thunderbird/60.6.0
MIME-Version: 1.0
In-Reply-To: <20190325173722.49414-1-steven.price@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


On 3/25/2019 11:07 PM, Steven Price wrote:
> of_parse_phandle_with_args() requires the caller to call of_node_put() on
> the returned args->np pointer. Otherwise the reference count will remain
> incremented.
>
> However, in this case, since we don't actually use the returned pointer,
> we can simply pass in NULL.
>
> Fixes: aa4f886f3893f ("firmware: arm_scmi: add basic driver infrastructure for SCMI")
> Signed-off-by: Steven Price <steven.price@arm.com>
> ---
>   drivers/firmware/arm_scmi/driver.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
> index 8f952f2f1a29..dd967d675c08 100644
> --- a/drivers/firmware/arm_scmi/driver.c
> +++ b/drivers/firmware/arm_scmi/driver.c
> @@ -654,9 +654,7 @@ static int scmi_xfer_info_init(struct scmi_info *sinfo)
>   
>   static int scmi_mailbox_check(struct device_node *np)
>   {
> -	struct of_phandle_args arg;
> -
> -	return of_parse_phandle_with_args(np, "mboxes", "#mbox-cells", 0, &arg);
> +	return of_parse_phandle_with_args(np, "mboxes", "#mbox-cells", 0, NULL);

Although, it is not used but it is better to put arg->np instead of 
passing NULL.
Here, you are making the driver not to fill arguement which is 
customised solution, that may change in future.


Thanks.
Mukesh


>   }
>   
>   static int scmi_mbox_free_channel(int id, void *p, void *data)