Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 26 Mar 2019 11:23:20 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     kbuild@01.org, Kangjie Lu <kjlu@umn.edu>
Cc:     usb-storage@lists.one-eyed-alien.net,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Alan Stern <stern@rowland.harvard.edu>, kbuild-all@01.org,
        pakki001@umn.edu
Subject: Re: [kbuild] [PATCH] usb: sierra: fix a missing check of
 device_create_file
Message-ID: <20190326082320.GG32613@kadam>
References: <20190324223920.961-1-kjlu@umn.edu>
 <20190326081831.GF32613@kadam>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20190326081831.GF32613@kadam>
User-Agent: Mutt/1.9.4 (2018-02-28)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 26, 2019 at 11:18:31AM +0300, Dan Carpenter wrote:
> 32fe5e393 Kevin Lloyd  2008-07-10  193  		}
> 32fe5e393 Kevin Lloyd  2008-07-10  194  		kfree(swocInfo);
>                                                         ^^^^^^^^^^^^^^^^
> 
> 32fe5e393 Kevin Lloyd  2008-07-10  195  	}
> 
> break statement?

Sorry, for some reason I saw "complete:" and read "default:". :/

But the warning seems valid.

regards,
dan carpenter

> 
> 32fe5e393 Kevin Lloyd  2008-07-10  196  complete:
> 32fe5e393 Kevin Lloyd  2008-07-10  197  	result = device_create_file(&us->pusb_intf->dev, &dev_attr_truinst);
> 04d66f3d0 Kangjie Lu   2019-03-24  198  	if (result) {
> 04d66f3d0 Kangjie Lu   2019-03-24 @199  		kfree(swocInfo);
>                                                         ^^^^^^^^^^^^^^^
> Double free.
>