Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 14/17] crypto: Don't mark AES tables const and
 cacheline_aligned
To:     Andi Kleen <andi@firstfloor.org>, x86@kernel.org
Cc:     akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
        Andi Kleen <ak@linux.intel.com>, herbert@gondor.apana.org.au
References: <20190321220009.29334-1-andi@firstfloor.org>
 <20190321220009.29334-15-andi@firstfloor.org>
From:   Rasmus Villemoes <linux@rasmusvillemoes.dk>
Message-ID: <58128cae-5871-64d8-0b4a-c1e3bb354e95@rasmusvillemoes.dk>
Date:   Tue, 26 Mar 2019 09:42:13 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.5.1
MIME-Version: 1.0
In-Reply-To: <20190321220009.29334-15-andi@firstfloor.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 21/03/2019 23.00, Andi Kleen wrote:
> From: Andi Kleen <ak@linux.intel.com>
> 
> cacheline_aligned is a special section. It cannot be const at the same
> time because it's not read-only. It doesn't give any MMU protection.

Urgh. Perhaps this instead just wanted to use the quadruple underscore
version, ____cacheline_aligned ? That would make these objects correctly
aligned and still live in .rodata, no?

Rasmus