Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <1553591536-3760-1-git-send-email-sugaya.taichi@socionext.com>
In-Reply-To: <1553591536-3760-1-git-send-email-sugaya.taichi@socionext.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 26 Mar 2019 10:57:08 +0100
Message-ID: <CAK8P3a0Sx5vxbserW27KMPYnpLabPkGJZ_2iuW9y082oHiO+aQ@mail.gmail.com>
Subject: Re: [PATCH] serial: Add Milbeaut serial control
To:     Sugaya Taichi <sugaya.taichi@socionext.com>
Cc:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jslaby@suse.com>,
        Takao Orito <orito.takao@socionext.com>,
        Kazuhiro Kasai <kasai.kazuhiro@socionext.com>,
        Shinji Kanematsu <kanematsu.shinji@socionext.com>,
        Jassi Brar <jaswinder.singh@linaro.org>,
        Masami Hiramatsu <masami.hiramatsu@linaro.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-serial@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 26, 2019 at 10:13 AM Sugaya Taichi
<sugaya.taichi@socionext.com> wrote:

>
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
> index 72966bc..961519b 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -1582,6 +1582,32 @@ config SERIAL_RDA_CONSOLE
>           Say 'Y' here if you wish to use the RDA8810PL UART as the system
>           console. Only earlycon is implemented currently.
>
> +config SERIAL_MILBEAUT_USIO
> +       tristate "Milbeaut USIO/UART serial port support"
> +       depends on ARCH_MILBEAUT
> +       default y
> +       select SERIAL_CORE
> +       help
> +         This selects the USIO/UART IP found in Socionext Milbeaut SoCs.

In general, it would be good to make it possible to build this on
other architectures for better compile test coverage, e.g. like

config SERIAL_MILBEAUT_USIO
     tristate "Milbeaut USIO/UART serial port support"
     depends on ARCH_MILBEAUT || COMPILE_TEST
     default ARCH_MILBEAUT

You might need additional dependencies like 'depends on OF'
to make this work reliably.

        Arnd