Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp4229251img; Tue, 26 Mar 2019 05:41:53 -0700 (PDT) X-Google-Smtp-Source: APXvYqzorvDdQ0zWvlTQROJW6uXuWRhra2462pGi0ABYtcp7PrvEnaBVvyM+un3q4VsZv6H+5hJu X-Received: by 2002:a65:624a:: with SMTP id q10mr1709192pgv.435.1553604113586; Tue, 26 Mar 2019 05:41:53 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553604113; cv=none; d=google.com; s=arc-20160816; b=WxxrqHKDSCR8hc/1DRh0aFFzC12/y0HsWjFss2Q4H7bVmhH796L/wEtOgC149iZAkO 4yVaZijjirGEmdo5H35R4UBEYmTrw8OyxX8ytDu/hfDqIg1uB8S2S2l5agSIgjJHX+WO lxlx7BZaz4PPX0Zj17FlZEIX37ARSJgxsMKCTduZO1y/7CqvwnatOX5/S6JTxWZKnrG7 jPFi+nft9w4t+rkfEgu7NQLJqzvHqFkCxvlEg8Z9lyeJyNBfqJjIMVTWAiOLtxDkEmk1 dn6gKp5H7C3SXCT4xXqaS1bajFyXeDWPS7ckwXgtW+IyZW0actT1+HFSfTYcClRxLTH9 yUCA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:mime-version:user-agent:references :message-id:in-reply-to:subject:cc:to:from:date; bh=EmvG+xc247W81HMqFuE+9Esfw5Hsm8TK+nbcXwq4Nq0=; b=qAk0PxDcyrpXdPNVIMw0I4HFQXonTiuRsgoUaODeOtifL0EysXZcRH6RbzewDNCfwB W7zpPvtdqFBWwaIAryO8A16qrDHsg9zGgvSpyU9UKf1a1je2+fi5n204N4qGhmMCQ1i3 cTn+0T7kxaK9cNNmQ0yYhKPXEehHXIMIdBN39lPITOAEwib9i8R23TZXhPiQWOSH2IHM gnabCepkyDEq8hOBsEmlAo6lT461I3akxLjUjjRDn099fhd7GwYMnPeWdO00vFK+pc5/ zHGgAV8LDWCyN0mr1PGfCwHmLzW+Kv+3mRswDvMhs4ywf7F35QBFFr3HQkvDdkKVSRST QVcA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q20si16450973plr.136.2019.03.26.05.41.38; Tue, 26 Mar 2019 05:41:53 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731357AbfCZMlE (ORCPT + 99 others); Tue, 26 Mar 2019 08:41:04 -0400 Received: from Galois.linutronix.de ([146.0.238.70]:48225 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726175AbfCZMlE (ORCPT ); Tue, 26 Mar 2019 08:41:04 -0400 Received: from p5492e2fc.dip0.t-ipconnect.de ([84.146.226.252] helo=nanos) by Galois.linutronix.de with esmtpsa (TLS1.2:DHE_RSA_AES_256_CBC_SHA256:256) (Exim 4.80) (envelope-from ) id 1h8lNx-0004aM-Ul; Tue, 26 Mar 2019 13:40:58 +0100 Date: Tue, 26 Mar 2019 13:40:57 +0100 (CET) From: Thomas Gleixner To: "Huang, Kai" cc: "jarkko.sakkinen@linux.intel.com" , "linux-kernel@vger.kernel.org" , "linux-sgx@vger.kernel.org" , "x86@kernel.org" , "Svahn, Kai" , "nhorman@redhat.com" , "Christopherson, Sean J" , "josh@joshtriplett.org" , "suresh.b.siddha@intel.com" , "Ayoun, Serge" , "Huang, Haitao" , "akpm@linux-foundation.org" , "npmccallum@redhat.com" , "rientjes@google.com" , "luto@kernel.org" , "Katz-zamir, Shay" , "Hansen, Dave" , "bp@alien8.de" , "andriy.shevchenko@linux.intel.com" Subject: Re: [PATCH v19,RESEND 16/27] x86/sgx: Add the Linux SGX Enclave Driver In-Reply-To: <1553601688.17255.12.camel@intel.com> Message-ID: References: <20190320162119.4469-1-jarkko.sakkinen@linux.intel.com> <20190320162119.4469-17-jarkko.sakkinen@linux.intel.com> <1553601688.17255.12.camel@intel.com> User-Agent: Alpine 2.21 (DEB 202 2017-01-01) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 26 Mar 2019, Huang, Kai wrote: > On Wed, 2019-03-20 at 18:21 +0200, Jarkko Sakkinen wrote: > > 13 files changed, 1657 insertions(+), 2 deletions(-) > > create mode 100644 arch/x86/include/uapi/asm/sgx.h > > create mode 100644 arch/x86/kernel/cpu/sgx/driver/Makefile > > create mode 100644 arch/x86/kernel/cpu/sgx/driver/driver.h > > create mode 100644 arch/x86/kernel/cpu/sgx/driver/ioctl.c > > create mode 100644 arch/x86/kernel/cpu/sgx/driver/main.c > > create mode 100644 arch/x86/kernel/cpu/sgx/encl.c > > create mode 100644 arch/x86/kernel/cpu/sgx/encl.h > > Shouldn't the driver be located somewhere under drivers/, but not under arch/x86? > > I don't think x86 maintainers should have the burden to review every code > change made to SGX driver? I rather prefer to have it in x86. Why? Because driver code has a tendency to get under the radar. Thanks, tglx