Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp4282393img; Tue, 26 Mar 2019 06:38:01 -0700 (PDT) X-Google-Smtp-Source: APXvYqwTCl59QP77d2Csu7jIGc9qhwDpTbloVTmhwYa5Te0Dd2dir1y+kWmWiCW815ydt6StLuJY X-Received: by 2002:a17:902:9a83:: with SMTP id w3mr31243517plp.137.1553607481006; Tue, 26 Mar 2019 06:38:01 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553607480; cv=none; d=google.com; s=arc-20160816; b=zwEK0lBvepewaIxvPFxf9CfhAZ40gpZ4gzA35nypt7SqKnGM7dOd1mNYfCMhmTINhl TyvKYQaV5yscMKkbs+Gbewt8hqU1j3xj5762/xLdIiRvswh6Pjqmb0iiQ6fS6pNHiXg1 3PkuFJpgnyZ8kAL9Y2RepGBe5t1g8bWex9ZkRuWJP58vsUK6LLud5sAynGCkk8zM7LUU 37Bvsbh/jQKSksOB6NiGnO0EgKLAw8w3Z+hVV4x2uBlpa5ixNUIqsojn7hhdGAW2ae2b n4jjbJrNYpYf9ZTA39f9+nN4rYsZNWwjSfyM1hqea3WFIy6Rqtr0UUdzKfFfNH+fkfe+ VrhQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=oBzqVXXOS16NvlFk14QPKS1+AWDX9qa0M3QDhL3KWfE=; b=CdRVooFE/+F12d2GyJm0uy9pxz4PGP/bUgxKcAPomlIgejm6NB/L2CpeB7XG3WHme0 3cyTPsqg0eC52ItJpqbsER/zEULV21o3rhtCbPiQ7CbzxK+sLWj0WCoeuxBjSmAuvBAc /xtUOSF3YI8YGGseEF9XemzQQUtGRNg82ygq36Ucwuh4NVYE2wmhtHKEu1oy7TdcpJl9 T0qEtZ8O5fvhUe80pJNs0AK7PMGWDJmwT2o9DnvdK220UwP8v/wdT/+JaPWyOTzOvveR qYzPu5odZOqnFKdJyn7+Mg4P1WTBBKMWz1ez3kwxJoTW1t1s18C8VBGI5COzq1qVRfZN sZaw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f7si399435pgq.522.2019.03.26.06.37.45; Tue, 26 Mar 2019 06:38:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731780AbfCZNgR (ORCPT + 99 others); Tue, 26 Mar 2019 09:36:17 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52700 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731768AbfCZNgO (ORCPT ); Tue, 26 Mar 2019 09:36:14 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5E10C308403E; Tue, 26 Mar 2019 13:36:13 +0000 (UTC) Received: from dhcp-27-174.brq.redhat.com (unknown [10.43.17.68]) by smtp.corp.redhat.com (Postfix) with SMTP id 4758A17A88; Tue, 26 Mar 2019 13:36:06 +0000 (UTC) Received: by dhcp-27-174.brq.redhat.com (nbSMTP-1.00) for uid 1000 oleg@redhat.com; Tue, 26 Mar 2019 14:36:12 +0100 (CET) Date: Tue, 26 Mar 2019 14:36:04 +0100 From: Oleg Nesterov To: Christopher Lameter Cc: Matthew Wilcox , Waiman Long , Andrew Morton , Pekka Enberg , David Rientjes , Joonsoo Kim , linux-kernel@vger.kernel.org, linux-mm@kvack.org, selinux@vger.kernel.org, Paul Moore , Stephen Smalley , Eric Paris , "Peter Zijlstra (Intel)" Subject: Re: [PATCH 2/4] signal: Make flush_sigqueue() use free_q to release memory Message-ID: <20190326133603.GB16837@redhat.com> References: <20190321214512.11524-1-longman@redhat.com> <20190321214512.11524-3-longman@redhat.com> <20190322015208.GD19508@bombadil.infradead.org> <20190322111642.GA28876@redhat.com> <01000169a686689d-bc18fecd-95e1-4b3e-8cd5-dad1b1c570cc-000000@email.amazonses.com> <93523469-48b0-07c8-54fd-300678af3163@redhat.com> <01000169a6ea5e46-f845b8db-730b-436e-980c-3e4273ad2e34-000000@email.amazonses.com> <20190322195926.GB10344@bombadil.infradead.org> <01000169b534b9e8-31a2af2c-c396-47f9-8534-4cbd934ef09d-000000@email.amazonses.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <01000169b534b9e8-31a2af2c-c396-47f9-8534-4cbd934ef09d-000000@email.amazonses.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.40]); Tue, 26 Mar 2019 13:36:14 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/25, Christopher Lameter wrote: > > On Fri, 22 Mar 2019, Matthew Wilcox wrote: > > > Only for SLAB and SLUB. SLOB requires that you pass a pointer to the > > slab cache; it has no way to look up the slab cache from the object. > > Well then we could either fix SLOB to conform to the others or add a > kmem_cache_free_rcu() variant. Speaking of struct sigqueue we can simply use call_rcu() but see my previous email, I am not sure this is the best option. Oleg.