Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp4313541img; Tue, 26 Mar 2019 07:10:17 -0700 (PDT) X-Google-Smtp-Source: APXvYqzV2KuXTRE1RHRiK60P4xRoqUNd9328m8j1IRQyOa2P8r8tofVvXTcQQFDxtWJBCjcN+phT X-Received: by 2002:a63:cc03:: with SMTP id x3mr28717752pgf.121.1553609417772; Tue, 26 Mar 2019 07:10:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553609417; cv=none; d=google.com; s=arc-20160816; b=uy0WZBw1tVOOMl3KXUtXMHxZaLBR6xkVISZ/eX364hSprqe2GCpa2uX/FaNZJghI8C UthwAg9lg2hXN9v/IZ2TmmiLwX2b1zZWI0+H6xJ0lXfSG3XRZyXITJ1Z44KEIo3TLX+w Lf6IeBJ05aGE1SjVTLS5sw54Wp9tz3I1FQe7w7MOuSFZJaGfqY3husBTbpPKE2orvAJ6 oDQmeFCOOlwPnuEgRZS73rD5VYRyTJqwNkohT7zKa1vLHKJZbg389VY67PRpCUeLTJ5n WFshSwVaLTzZcFCKaf41zK4Osxnp7EiuH2Ey026TKD1R4bSNCWerpOEcBbFNHRsKvX3D t8gQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=PmCiw7U2fRSButHB7uTB0IgSTpuxr7FUffBuDlrMWYU=; b=JRdqTiWWnl2LjO1AIPJFiQOjvOytsPpeILA1y1mugbf9Dqyd7+9evLLuzoYW5hbtO6 vknV1+U0Wf8EJ650SYrZ8OHlsT4OPE18fZWHnrvy7yQlv8+ijCdBU1yEh+N/KdJgu66/ wCFfGQatdgnnGOTO/o3prugF65D4TwOo22VTU4eKsqEp2KKzl3lY9Wdkk9KbMCZqEuX5 /RGRuUh/sk0xW6QD1RWbHnj9WBT6Zbzz73/Llok0bo3BynvWmmuWR34stGTvYrzBb1y6 YHcPTMKtxpNAVbQd7JFZUtgZGwSb8G0JR7teBohyD4Fz4C/U7pHntk2iZwoplx943RH5 FpPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=FA+sFyXy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r133si16244490pgr.175.2019.03.26.07.10.01; Tue, 26 Mar 2019 07:10:17 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel-dk.20150623.gappssmtp.com header.s=20150623 header.b=FA+sFyXy; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731660AbfCZOJR (ORCPT + 99 others); Tue, 26 Mar 2019 10:09:17 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:42785 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726177AbfCZOJQ (ORCPT ); Tue, 26 Mar 2019 10:09:16 -0400 Received: by mail-io1-f68.google.com with SMTP id c4so10856698ioh.9 for ; Tue, 26 Mar 2019 07:09:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PmCiw7U2fRSButHB7uTB0IgSTpuxr7FUffBuDlrMWYU=; b=FA+sFyXyOczcfou8jmtTknHLR9ZpFntjUzctPLiqhK9ANYNDOcLgBqiFCpIIawAWgt ltL3Y4kyqdUpJZsSgDP7ReaTIIZiL2VvSXFLbqY7lBjfHjciciJzi8KqndLiEAlgdWMI jf0Ju3oLv2s4/kbneUjJYgoyUA74PAi6QIv77gxbEhlDArw/NFyMZrJP5E/cj8pTVnrX w7jqQThI9GBqQ/bI32foHWCspJZT4e8DDTtEs6ZeMQAgR0yy8DLnunRERt3gFUUORLx7 PLsbqsEPEEvWoszD7irjMZc64lAseQs2IzGA3dLijIr8sV6APBegJGmm2sOQx3IE7NM5 1L3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PmCiw7U2fRSButHB7uTB0IgSTpuxr7FUffBuDlrMWYU=; b=Ze8MC0Lhz0s2K3v9JjbaiVKBbsEEs0p3l2sAlt6dX86M+hSG4IGUsTgafELPAPDUli 5bthG7BuLgjN0N6tVnn94bjZukwLHgcmSN7hKi8mD7EeHUwYZrXxfV/pxq9Qyfpel6Ml RepiQaHaV5oymJHwpUWr+0RTUXPmT05vHnfzMvnjsjZxUnnEu4gHAwA5wIpZyYuZwPxg Yva2kD4cZe4Cd33My6TtFlkG9H6qNhernrSoLIAZb5COk4IU98JYJiGZtwTnCriSp5rz koi3MpphmZuQq60VmmgA70tULvhr+wPOSjfUSc+ax6vXi3Zba2Dix91ldTtvJtHsQ+f+ byWQ== X-Gm-Message-State: APjAAAW3Y8gbY+bOYFVJvLt+0IwLFf3p4v6sL+sbFn5Mw9zt31dSkcLp kpn7kNIWJc6YKHY5138IZ1Ly0w== X-Received: by 2002:a5d:8b41:: with SMTP id c1mr21277241iot.173.1553609355878; Tue, 26 Mar 2019 07:09:15 -0700 (PDT) Received: from [192.168.1.158] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id h78sm6184075ita.30.2019.03.26.07.09.14 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 07:09:14 -0700 (PDT) Subject: Re: [PATCH] libata: fix using DMA buffers on stack To: raymond pang Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org References: From: Jens Axboe Message-ID: <742c1607-1e28-3674-65ca-8e5f111e243e@kernel.dk> Date: Tue, 26 Mar 2019 08:09:13 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/25/19 9:07 PM, raymond pang wrote: > When CONFIG_VMAP_STACK=y, __pa() returns incorrect physical address for > a stack virtual address. Stack DMA buffers must be avoided. The patch looks fine, but it's white space mangled so it won't apply. Additionally, you don't need to use kzfree, just use kfree. -- Jens Axboe