Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Tue, 26 Mar 2019 07:54:52 -0700
From:   Sean Christopherson <sean.j.christopherson@intel.com>
To:     Thomas Gleixner <tglx@linutronix.de>
Cc:     "Huang, Kai" <kai.huang@intel.com>,
        "jarkko.sakkinen@linux.intel.com" <jarkko.sakkinen@linux.intel.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-sgx@vger.kernel.org" <linux-sgx@vger.kernel.org>,
        "x86@kernel.org" <x86@kernel.org>,
        "Svahn, Kai" <kai.svahn@intel.com>,
        "nhorman@redhat.com" <nhorman@redhat.com>,
        "josh@joshtriplett.org" <josh@joshtriplett.org>,
        "suresh.b.siddha@intel.com" <suresh.b.siddha@intel.com>,
        "Ayoun, Serge" <serge.ayoun@intel.com>,
        "Huang, Haitao" <haitao.huang@intel.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "npmccallum@redhat.com" <npmccallum@redhat.com>,
        "rientjes@google.com" <rientjes@google.com>,
        "luto@kernel.org" <luto@kernel.org>,
        "Katz-zamir, Shay" <shay.katz-zamir@intel.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        "bp@alien8.de" <bp@alien8.de>,
        "andriy.shevchenko@linux.intel.com" 
        <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v19,RESEND 16/27] x86/sgx: Add the Linux SGX Enclave
 Driver
Message-ID: <20190326145452.GD3757@linux.intel.com>
References: <20190320162119.4469-1-jarkko.sakkinen@linux.intel.com>
 <20190320162119.4469-17-jarkko.sakkinen@linux.intel.com>
 <1553601688.17255.12.camel@intel.com>
 <alpine.DEB.2.21.1903261340030.1789@nanos.tec.linutronix.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <alpine.DEB.2.21.1903261340030.1789@nanos.tec.linutronix.de>
User-Agent: Mutt/1.5.24 (2015-08-30)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Mar 26, 2019 at 01:40:57PM +0100, Thomas Gleixner wrote:
> On Tue, 26 Mar 2019, Huang, Kai wrote:
> > On Wed, 2019-03-20 at 18:21 +0200, Jarkko Sakkinen wrote:
> > >  13 files changed, 1657 insertions(+), 2 deletions(-)
> > >  create mode 100644 arch/x86/include/uapi/asm/sgx.h
> > >  create mode 100644 arch/x86/kernel/cpu/sgx/driver/Makefile
> > >  create mode 100644 arch/x86/kernel/cpu/sgx/driver/driver.h
> > >  create mode 100644 arch/x86/kernel/cpu/sgx/driver/ioctl.c
> > >  create mode 100644 arch/x86/kernel/cpu/sgx/driver/main.c
> > >  create mode 100644 arch/x86/kernel/cpu/sgx/encl.c
> > >  create mode 100644 arch/x86/kernel/cpu/sgx/encl.h
> > 
> > Shouldn't the driver be located somewhere under drivers/, but not under arch/x86?
> > 
> > I don't think x86 maintainers should have the burden to review every code
> > change made to SGX driver?
> 
> I rather prefer to have it in x86. Why? Because driver code has a tendency
> to get under the radar.

And having everything under arch/x86 will likely reduce the maintenance
burden for everyone:

   - Doesn't require taking changes through multiple trees or coordinating
     acks from multiple maintainers.

   - Significantly reduces the number of functions, macros, structs and
     variables that needs to be exposed in asm/sgx.h (actually eliminates
     it entirely at this point) which allows for sane code organization as
     opposed to dumping everything in one big header.

   - Mostly avoids bikeshedding over whether something is architectural
     or belongs in the so called driver.