Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp4441951img; Tue, 26 Mar 2019 09:27:31 -0700 (PDT) X-Google-Smtp-Source: APXvYqzhUXad+KvYLZDfoDbSsUNH+jao+EZ4gjdZeRqKRLJZmXH/uw8g04oACPKVRO5U59ewYIB5 X-Received: by 2002:aa7:9090:: with SMTP id i16mr29605627pfa.85.1553617651808; Tue, 26 Mar 2019 09:27:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553617651; cv=none; d=google.com; s=arc-20160816; b=WRWNJXjTeZloLOtM4ZabnxwWyMgB71ADx2dm/8cx7JhXhk4zcIO4qX0VOzzGR1sVWg OVNBSpWDCK4WKYU7eAP4Kui1RuGaM/7s/8CAR5T+oL4OozsIuOqHnU+dNqGJkDk1uolh 92as2PQZ1P1XrUvW6bc2aV8iCQTL27BkMkvZBKNUwOXgV9UW/CF19sQNZYDK8P33d7rR GIjuTyz9Bac7g2tFqYnZI8xGjy//Mmxne2zTftKuGR51tYiW61NzOMjh6VU6xV8P7bmU oZVxuwtTJl627x4/SlK7d0YeQU8XcSQY6dT0DErLAMbZjONIwVYpip1GLqIYfsKgdJH6 xQ8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=KFvapMbUm3bXfRm+QdzupSk/zuyCEmTqI4EjOBRlsz4=; b=KxEHs4Rt49yK9pwhMl2ul8o1l1FlVodrsHpur2BDbPAgJGhWcqTz8XYu53h0zSsys5 4mXm5hNe3du3+ywLoLbLRlxFiNKgapSIdsd4VJzEr19yBiu1ZPrBYxF3qP/WCcly0Gso jTEwAKkpw2Bgp4mqQaitzmo7gKF82PYnj3d+VqVAzv8+Gjuq+oDfegw5SA4hb/mZVHrW 6S3XZXVS6LmskBWzfOXgJjM0JcDI2Vv8IhRi9vnmpysvLJvIElD/kZSTUQilWVTPphvE rLQXghj+Xz6o1W41Nf5sZf8xJxKLqkPrOxzP1C3LRTW4zFComHD4qUg3SRo6WY+U2lRN 9+PA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o1si16063576pgk.582.2019.03.26.09.27.16; Tue, 26 Mar 2019 09:27:31 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731540AbfCZQ0g (ORCPT + 99 others); Tue, 26 Mar 2019 12:26:36 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:39490 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727492AbfCZQ0g (ORCPT ); Tue, 26 Mar 2019 12:26:36 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 667D01596; Tue, 26 Mar 2019 09:26:35 -0700 (PDT) Received: from e112269-lin.arm.com (e112269-lin.cambridge.arm.com [10.1.196.69]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 2A9DF3F614; Tue, 26 Mar 2019 09:26:32 -0700 (PDT) From: Steven Price To: linux-mm@kvack.org Cc: Steven Price , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Dave Hansen , Ingo Molnar , James Morse , =?UTF-8?q?J=C3=A9r=C3=B4me=20Glisse?= , Peter Zijlstra , Thomas Gleixner , Will Deacon , x86@kernel.org, "H. Peter Anvin" , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Mark Rutland , "Liang, Kan" Subject: [PATCH v6 00/19] Convert x86 & arm64 to use generic page walk Date: Tue, 26 Mar 2019 16:26:05 +0000 Message-Id: <20190326162624.20736-1-steven.price@arm.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Most architectures current have a debugfs file for dumping the kernel page tables. Currently each architecture has to implement custom functions for walking the page tables because the generic walk_page_range() function is unable to walk the page tables used by the kernel. This series extends the capabilities of walk_page_range() so that it can deal with the page tables of the kernel (which have no VMAs and can contain larger huge pages than exist for user space). x86 and arm64 are then converted to make use of walk_page_range() removing the custom page table walkers. To enable a generic page table walker to walk the unusual mappings of the kernel we need to implement a set of functions which let us know when the walker has reached the leaf entry. Since arm, powerpc, s390, sparc and x86 all have p?d_large macros lets standardise on that and implement those that are missing. Potentially future changes could unify the implementations of the debugfs walkers further, moving the common functionality into common code. This would require a common way of handling the effective permissions (currently implemented only for x86) along with a per-arch way of formatting the page table information for debugfs. One immediate benefit would be getting the KASAN speed up optimisation in arm64 (and other arches) which is currently only implemented for x86. Also available as a git tree: git://linux-arm.org/linux-sp.git walk_page_range/v6 Changes since v5: * Updated comment for struct mm_walk based on Mike Rapoport's suggestion Changes since v4: * Correctly force result to a boolean in p?d_large for powerpc. * Added Acked-bys * Rebased onto v5.1-rc1 Changes since v3: * Restored the generic macros, only implement p?d_large() for architectures that have support for large pages. This also means adding dummy #defines for architectures that define p?d_large as static inline to avoid picking up the generic macro. * Drop the 'depth' argument from pte_hole * Because we no longer have the depth for holes, we also drop support in x86 for showing missing pages in debugfs. See discussion below: https://lore.kernel.org/lkml/26df02dd-c54e-ea91-bdd1-0a4aad3a30ac@arm.com/ * mips: only define p?d_large when _PAGE_HUGE is defined. Changes since v2: * Rather than attemping to provide generic macros, actually implement p?d_large() for each architecture. Changes since v1: * Added p4d_large() macro * Comments to explain p?d_large() macro semantics * Expanded comment for pte_hole() callback to explain mapping between depth and P?D * Handle folded page tables at all levels, so depth from pte_hole() ignores folding at any level (see real_depth() function in mm/pagewalk.c) Steven Price (19): arc: mm: Add p?d_large() definitions arm64: mm: Add p?d_large() definitions mips: mm: Add p?d_large() definitions powerpc: mm: Add p?d_large() definitions riscv: mm: Add p?d_large() definitions s390: mm: Add p?d_large() definitions sparc: mm: Add p?d_large() definitions x86: mm: Add p?d_large() definitions mm: Add generic p?d_large() macros mm: pagewalk: Add p4d_entry() and pgd_entry() mm: pagewalk: Allow walking without vma mm: pagewalk: Add test_p?d callbacks arm64: mm: Convert mm/dump.c to use walk_page_range() x86: mm: Don't display pages which aren't present in debugfs x86: mm: Point to struct seq_file from struct pg_state x86: mm+efi: Convert ptdump_walk_pgd_level() to take a mm_struct x86: mm: Convert ptdump_walk_pgd_level_debugfs() to take an mm_struct x86: mm: Convert ptdump_walk_pgd_level_core() to take an mm_struct x86: mm: Convert dump_pagetables to use walk_page_range arch/arc/include/asm/pgtable.h | 1 + arch/arm64/include/asm/pgtable.h | 2 + arch/arm64/mm/dump.c | 117 +++---- arch/mips/include/asm/pgtable-64.h | 8 + arch/powerpc/include/asm/book3s/64/pgtable.h | 30 +- arch/powerpc/kvm/book3s_64_mmu_radix.c | 12 +- arch/riscv/include/asm/pgtable-64.h | 7 + arch/riscv/include/asm/pgtable.h | 7 + arch/s390/include/asm/pgtable.h | 2 + arch/sparc/include/asm/pgtable_64.h | 2 + arch/x86/include/asm/pgtable.h | 10 +- arch/x86/mm/debug_pagetables.c | 8 +- arch/x86/mm/dump_pagetables.c | 347 ++++++++++--------- arch/x86/platform/efi/efi_32.c | 2 +- arch/x86/platform/efi/efi_64.c | 4 +- include/asm-generic/pgtable.h | 19 + include/linux/mm.h | 26 +- mm/pagewalk.c | 76 +++- 18 files changed, 407 insertions(+), 273 deletions(-) -- 2.20.1