Received: by 2002:ac0:bc90:0:0:0:0:0 with SMTP id a16csp4517965img; Tue, 26 Mar 2019 10:57:00 -0700 (PDT) X-Google-Smtp-Source: APXvYqzTIJLvPIo+eBQpD+rrODYPNiqJIS2nOs2S8eGGEejpy5RyL/p/BtNM2hTFnsmsWZop+xUB X-Received: by 2002:a17:902:3381:: with SMTP id b1mr22974272plc.5.1553623020560; Tue, 26 Mar 2019 10:57:00 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553623020; cv=none; d=google.com; s=arc-20160816; b=oVsRbUubG0pKSTKCN0BJIE38fst81O/lGcCEEmBED0ssS9F4+43VS5qGZa3IxC4v/V zrNH1wruma3mdTnX4WKC9ajJL16dkdCc6Ku5z3YIEmyl/gBuE4wLT+etHZYf6R8bc7mT 3uKVa/+tchJZkXyzvgWAuGguTxhn+NX2AtsmRDGQIo8f/RJVz07F7Q0Yaj46m8YpwJt6 /AuyiFSEknCaE7WbJQ5HKXglnzUu4CSPnJNrrdEw/elQne+IgPvNnFnvIscIWe6nTfz0 pNl1VdnmNHuUEZoTrbqjaFbag8Q5vxDbP36ncvl4bx3nqrSzV/4LXCY12QStXcbKwFq1 HVAQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=EokdJk0jdZKei/GtsxXIf6RBVdRcX2HGb5Qo163dW3M=; b=mEliRY/1mfc45CIKE7F3S+jiQyxDW2n2JgomBeljypurrry8Z04btdwkMA+lfHURyG p+a+FsgPqK1IDsftt0ipBtYcZX/9CC8KiinDwjEA1CzV8o06CIwxO7rSTuVh3B6iF0H5 1O6EOue/dVx5ZC/FiR37LC6Jh+0HPhsAjIQu1q63V1BrmsAmEUnEgV2WmdV+fgwSQHA/ ecSBh4ruO9qSd3gAY9Tednkm3CR1X1U4VlqWk7UTAzaPoz8xbXTuDTCAqz9j4SdhtbNu eE2xwwERDB0mxXuPIR9EkqbngGlPlU1vgJlU4+vHBSZpvO/bOnn3mvMrs6k3m8C6cjoA io9Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=jcjFcCTa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id f89si18470059plb.20.2019.03.26.10.56.44; Tue, 26 Mar 2019 10:57:00 -0700 (PDT) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@google.com header.s=20161025 header.b=jcjFcCTa; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=REJECT sp=REJECT dis=NONE) header.from=google.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732066AbfCZR4K (ORCPT + 99 others); Tue, 26 Mar 2019 13:56:10 -0400 Received: from mail-it1-f171.google.com ([209.85.166.171]:54765 "EHLO mail-it1-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729800AbfCZR4K (ORCPT ); Tue, 26 Mar 2019 13:56:10 -0400 Received: by mail-it1-f171.google.com with SMTP id w18so21060701itj.4 for ; Tue, 26 Mar 2019 10:56:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EokdJk0jdZKei/GtsxXIf6RBVdRcX2HGb5Qo163dW3M=; b=jcjFcCTaZET+wKT/MDTuz6ncFZ3fkmub6+/VZ/WG7LrK+6i7VTOmqfgNpHyAvFDhC7 tqbjHdQsj2z624p76D+mDzFThq1lA7GZK0HolHAhSejSS9+TTEypxqqL8TZSDEp3srNs pbB1S88P3GRrVtmQyv3jqUWQm5ipA4Wy/8VN2lCozdFqqOQzJELYKILUrjwEFQjKmQ5s L9L/di2sly2TvkyqWvOWszP/5zoKRf6NS0L9c/PmGqRcdX30jEZSNPxMU3288C/Iw+oX lGyOts9KJa5OzGvDMQP1IxXsbMkKgGcLOhSebXmiPf0JO5zENwYdjxg3egx1uThO24BF eSew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EokdJk0jdZKei/GtsxXIf6RBVdRcX2HGb5Qo163dW3M=; b=c4w5uG/959IiBjUQfSip4neby+lxrNg5d0xRaCK3cukYMfOCcYLRCn+7ha/E1F2ZSK 1L+NbKwk/5a1auDFr5fJ7C4cA/KRK5bb3bK30RbQUCiYXsVUs8nbuUz/47vmuR1CCOYR TRAP1G8H5mU5W1Z9XU6eIHah4uP1dmrytdJLfN5DcsnXoXmPvIDeN31JLZZuh6jlKBVF czuoOEOhy+bJ++D1rzhFiefUj082bgl4tiY5tdND2qfnmuGvbPcws0aFpGAkmWdp9n97 9HaLJEJbhgfVEv0VNIQtB75DeTW/m1Q/OiJCNb40mhMpBvpGJFLUe2wdi3WlE6/zjnJ3 dDKA== X-Gm-Message-State: APjAAAW5zlSASVqMTNUBaB9owZPDAJEvRCL8eB16MMjkyvhz1ZV+Dry+ 0GLH2MNE2BE/Zh2Jkj3T4ksuaf6lmt3nY1Ftk272HQ== X-Received: by 2002:a24:2c48:: with SMTP id i69mr104352iti.161.1553622968800; Tue, 26 Mar 2019 10:56:08 -0700 (PDT) MIME-Version: 1.0 References: <81d0122d14c4fbb3a2ad33d25fdf2dd001c7dcc7.1552737854.git.rgb@redhat.com> <20190321005008.wfz3bk7q262km5fz@madcap2.tricolour.ca> <2006016.NXIvICiRTL@x2> <1553614157.4115.17.camel@linux.ibm.com> <20190326161409.3wej7hcwnqalf4or@madcap2.tricolour.ca> <20190326174252.irqrldtcy5bwho6k@madcap2.tricolour.ca> In-Reply-To: <20190326174252.irqrldtcy5bwho6k@madcap2.tricolour.ca> From: Matthew Garrett Date: Tue, 26 Mar 2019 10:55:57 -0700 Message-ID: Subject: Re: [PATCH ghak109 V1] audit: link integrity evm_write_xattrs record to syscall event To: Richard Guy Briggs Cc: Mimi Zohar , Steve Grubb , Paul Moore , linux-integrity , LSM List , Linux-Audit Mailing List , LKML , omosnace@redhat.com, Eric Paris , Serge Hallyn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 26, 2019 at 10:43 AM Richard Guy Briggs wrote: > Ok, what I typed above wasn't quite what I intended... This is what I > meant: > > audit_log_format(ab, "xattr="); > audit_log_untrustedstring(ab, "."); > > But, I'll just move the normal case above the "." locking detection and > log all cases the same way. Sounds good to me.