Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   <Mario.Limonciello@dell.com>
Cc:     <linux-usb@vger.kernel.org>, <netdev@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <hayeswang@realtek.com>,
        <sjg@google.com>, <campello@google.com>, <Ryan.Hong@Dell.com>,
        <Crag.Wang@dell.com>
To:     <davem@davemloft.net>
Subject: RE: [PATCH] r8152: Refresh MAC address during USBDEVFS_RESET
Thread-Topic: [PATCH] r8152: Refresh MAC address during USBDEVFS_RESET
Thread-Index: AQHU4xTHuLEGWwasfk+zBAknUygSNqYel1KA//+9ILA=
Date:   Tue, 26 Mar 2019 19:52:50 +0000
Message-ID: <f1d2f070fd124fe3bc83a7d6535a61ef@ausx13mpc120.AMER.DELL.COM>
References: <1553523143-23072-1-git-send-email-mario.limonciello@dell.com>
 <20190326.115051.1713861149387592628.davem@davemloft.net>
In-Reply-To: <20190326.115051.1713861149387592628.davem@davemloft.net>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

> -----Original Message-----
> From: David Miller <davem@davemloft.net>
> Sent: Tuesday, March 26, 2019 1:51 PM
> To: Limonciello, Mario
> Cc: linux-usb@vger.kernel.org; netdev@vger.kernel.org; linux-
> kernel@vger.kernel.org; hayeswang@realtek.com; sjg@google.com;
> campello@google.com; Hong, Ryan; Wang, Crag
> Subject: Re: [PATCH] r8152: Refresh MAC address during USBDEVFS_RESET
>=20
>=20
> [EXTERNAL EMAIL]
>=20
> From: Mario Limonciello <mario.limonciello@dell.com>
> Date: Mon, 25 Mar 2019 09:12:23 -0500
>=20
> > On some platforms it is possible to dynamically change the policy
> > of what MAC address is selected from the ASL at runtime.
> >
> > These tools will reset the USB device and expect the change to be
> > made immediately.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@dell.com>
>=20
> You are going to have to emit CHANGEADDR notifications and such if
> necessary when you do this.

Thanks for the feedback, I'll add that call.  Do you feel a need that the M=
AC
address needs to be tracked and compared to what was previously in ACPI
table to know it "really" changed or just emit CHANGEADDR because it "might=
"
have changed?